Remove ATLAS

[Matthias Köppe]

(from #19719)

Our version of ATLAS is outdated and has not been tested in a long time. Latest upstream version as of 2021-09-21 is 3.11.40, released 2018-10-02, see ​​https://github.com/math-atlas/math-atlas/releases

We remove this package.

However, we keep the makefile variable BLAS (used in packages' dependencies files), rather than hardcoding openblas in dependencies. It will make it easier to plug in another BLAS implementation if one comes along in the future, and it is also needed for #29387.

[John Palmieri]

Here is an attempt. I have questions:

• what to do with openblas/spkg-configure.m4? Any changes necessary?
• what about the spkg-install.in scripts for scipy and numpy? They refer to an ATLAS environment variable. Leave as is or change?
• I don't know anything about cygwin, so I don't know what to do about the installation instructions referring to ATLAS in src/doc/en/installation/source.rst.

Anyway, this is a start.

---

New commits:

​3c3022c

trac 30350: remove the ATLAS package

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​0afdab5

trac 30350: remove the ATLAS package

[Matthias Köppe]

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

[Matthias Köppe]

I support removing this package in 9.5. The branch needs rebasing

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​8ba1d79

trac 30350: remove the ATLAS package

[John Palmieri]

Rebased. I deleted the reference to ATLAS in the cygwin instructions in src/doc/en/installation/source.rst, but the other questions in comment:4 remain.

[Matthias Köppe]

Replying to jhpalmieri:

• what to do with openblas/spkg-configure.m4? Any changes necessary?

We could either keep the --with-blas=... option but make it an error if anything other than openblas is passed, or remove it.

[Matthias Köppe]

Replying to jhpalmieri:

• what about the spkg-install.in scripts for scipy and numpy? They refer to an ATLAS environment variable. Leave as is or change?

No change needed. The scripts just set the environment variable to a safe value so the installation does not pick up random things that may be in the user's environment. (Not sure why the default is different for macOS and for other systems.)

[Matthias Köppe]

The changes to the documentation look fine.

[John Palmieri]

Is this the way to remove the --with-blas option?

build/pkgs/openblas/spkg-configure.m4

@@ -110 +110 @@
   LIBS="$SAVE_LIBS"
   CFLAGS="$SAVE_CFLAGS"
  ])
- ], [
-  dnl REQUIRED-CHECK
-  AS_IF([test "x$with_blas" = xopenblas], [
-     sage_require_openblas=yes
-     sage_require_atlas=no])
-  ], [
-  dnl PRE
-  AC_MSG_CHECKING([BLAS library])
-  AC_ARG_WITH([blas],
-  [AS_HELP_STRING([--with-blas=openblas],
-    [use OpenBLAS as BLAS library (default)])]
-  [AS_HELP_STRING([--with-blas=atlas],
-    [use ATLAS as BLAS library])],,
-    [with_blas=openblas]  # default
-  )
-  AS_CASE(["$with_blas"],
-    [openblas], [],
-    [atlas],    [sage_spkg_install_openblas=no],
-                [AC_MSG_ERROR([allowed values for --with-blas are 'atlas' and 'openblas'])])
-  AC_MSG_RESULT([$with_blas])
-  AC_SUBST([SAGE_BLAS], [$with_blas])
-  ]
+ ]
 )

[Matthias Köppe]

Yes, that looks right

[Matthias Köppe]

After removing, this line:

build/make/Makefile.in:BLAS = @SAGE_BLAS@

needs changing

[John Palmieri]

Can I just change it to BLAS = openblas?

[Matthias Köppe]

Yes

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​69db839

trac 30350: remove "--with-blas=" option to ./configure

[John Palmieri]

Okay, here are those changes.

[Matthias Köppe]

build/pkgs/atlas/distros/ still contains some stuff

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​272424a

trac 30350: remove remaining bits in build/pkgs/atlas/distros

[John Palmieri]

Fixed, thanks.

[Matthias Köppe]

This seems to work well.

[John Palmieri]

Thank you!