Opened 23 months ago
Closed 22 months ago
#30347 closed enhancement (fixed)
fix some lgtm suggestions
| Reported by: | chapoton | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-9.2 |
| Component: | refactoring | Keywords: | |
| Cc: | Merged in: | ||
| Authors: | Frédéric Chapoton | Reviewers: | Sébastien Labbé, David Lowry-Duda |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 4fca41e (Commits, GitHub, GitLab) | Commit: | 4fca41eb2c61c6082019129c8e833d4e9121c446 |
| Dependencies: | Stopgaps: |
Status badges
Description
about imprecise asserts and unused imports
It seems that some recent changes in the coding folder did not care at all about pyflakes warnings.
Change History (11)
comment:1 Changed 23 months ago by
- Branch set to u/chapoton/30347
- Commit set to d5770510b6596d2a328bb5d5a124e99b01e73872
- Status changed from new to needs_review
comment:2 Changed 23 months ago by
some of the bad things come from #20970
comment:3 Changed 23 months ago by
- Commit changed from d5770510b6596d2a328bb5d5a124e99b01e73872 to 27e6d922c5cd83c8e0d1b3d840349a614a312026
Branch pushed to git repo; I updated commit sha1. New commits:
| 27e6d92 | more lgtm fixes
|
comment:4 Changed 23 months ago by
le patchbot dit:
src/sage/rings/padics/factory.py:57:1 'from .padic_extension_leaves import *' used; unable to detect undefined names src/sage/rings/padics/factory.py:58:1 'from .relative_extension_leaves import *' used; unable to detect undefined names src/sage/rings/padics/factory.py:63:44 'EisensteinExtensionFieldCappedRelative' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:64:43 'EisensteinExtensionRingCappedAbsolute' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:65:43 'EisensteinExtensionRingCappedRelative' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:66:37 'EisensteinExtensionRingFixedMod' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:73:44 'UnramifiedExtensionFieldCappedRelative' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:74:43 'UnramifiedExtensionRingCappedAbsolute' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:75:43 'UnramifiedExtensionRingCappedRelative' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:76:37 'UnramifiedExtensionRingFixedMod' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:77:42 'UnramifiedExtensionRingFloatingPoint' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:78:43 'UnramifiedExtensionFieldFloatingPoint' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:79:38 'RelativeRamifiedExtensionRingFixedMod' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:80:44 'RelativeRamifiedExtensionRingCappedAbsolute' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:81:44 'RelativeRamifiedExtensionRingCappedRelative' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:82:45 'RelativeRamifiedExtensionFieldCappedRelative' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:83:43 'RelativeRamifiedExtensionRingFloatingPoint' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:84:44 'RelativeRamifiedExtensionFieldFloatingPoint' may be undefined, or defined from star imports: .padic_extension_leaves, .relative_extension_leaves src/sage/rings/padics/factory.py:218:13 local variable 'print_unram_name' is assigned to but never used found 19 pyflakes errors in the modified files
do you want to fix them too?
comment:5 Changed 23 months ago by
- Status changed from needs_review to needs_work
je le mets en needs work
comment:6 Changed 23 months ago by
- Reviewers set to Sébastien Labbé
comment:7 Changed 23 months ago by
- Commit changed from 27e6d922c5cd83c8e0d1b3d840349a614a312026 to 4fca41eb2c61c6082019129c8e833d4e9121c446
Branch pushed to git repo; I updated commit sha1. New commits:
| 4fca41e | more pyflakes fixes in padics
|
comment:8 Changed 23 months ago by
- Status changed from needs_work to needs_review
comment:9 Changed 23 months ago by
sage -btp src/sage/coding src/sage/rings src/sage/tensor/ src/sage/combinat/root_system/ me retourne all test passed. J'attends le retour du patchbot.
comment:10 Changed 23 months ago by
- Reviewers changed from Sébastien Labbé to Sébastien Labbé, David Lowry-Duda
- Status changed from needs_review to positive_review
Tous les tests avec patchbot et moi. Bon travail.
comment:11 Changed 22 months ago by
- Branch changed from u/chapoton/30347 to 4fca41eb2c61c6082019129c8e833d4e9121c446
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
fixing a bunch of lgtm suggestions (imprecise asserts, unused imports)