Opened 2 years ago
Closed 2 years ago
#30324 closed defect (invalid)
Add ipywidgets as a dependency to packages using the sage doctester
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sageduplicate/invalid/wontfix 
Component:  packages: optional  Keywords:  
Cc:  slelievre, fbissey, frederichan  Merged in:  
Authors:  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  Commit:  
Dependencies:  #29766  Stopgaps: 
Description
Followup from #29426:
Currently giacpy_sage tests fail (https://github.com/mkoeppe/sage/runs/959684347) because its sagecheck
needs the sage doctester
Change History (14)
comment:1 Changed 2 years ago by
Dependencies:  → #29766 

comment:2 Changed 2 years ago by
Branch:  → u/mkoeppe/add_ipywidgets_as_a_dependency_to_packages_using_the_sage_doctester 

comment:3 Changed 2 years ago by
Commit:  → 4ddcc6fa71ba001bef34162462adde613e00eb2a 

Reviewers:  → https://github.com/mkoeppe/sage/actions/runs/201918837 
comment:4 Changed 2 years ago by
Status:  new → needs_review 

comment:5 Changed 2 years ago by
Commit:  4ddcc6fa71ba001bef34162462adde613e00eb2a → 813bbf72f67e9d48ca41df5ff1efed1cd8013736 

Branch pushed to git repo; I updated commit sha1. New commits:
813bbf7  build/pkgs/giacpy_sage/dependencies: Fixup: Need SAGERUNTIME for installing

comment:6 Changed 2 years ago by
Reviewers:  https://github.com/mkoeppe/sage/actions/runs/201918837 → github.com/mkoeppe/sage/actions/runs/202669190 

comment:7 Changed 2 years ago by
Cc:  fbissey frederichan added 

comment:9 Changed 2 years ago by
debianstretchmaximal
(https://github.com/mkoeppe/sage/runs/967227907)
Running the test suite for giacpy_sage0.6.8... ... from .widgets_sagenb import (input_box, text_control, slider, File "/sage/local/lib/python3.7/sitepackages/sage/repl/ipython_kernel/widgets_sagenb.py", line 30, in <module> from ipywidgets.widgets import (IntSlider, IntRangeSlider, FloatSlider, ModuleNotFoundError: No module named 'ipywidgets'
comment:10 Changed 2 years ago by
... and I thought I had fixed the SAGE_CHECK_... business in #29766...
comment:11 Changed 2 years ago by
Status:  needs_review → needs_work 

comment:12 Changed 2 years ago by
Authors:  Matthias Koeppe 

Milestone:  sage9.2 → sageduplicate/invalid/wontfix 
Reviewers:  github.com/mkoeppe/sage/actions/runs/202669190 
Status:  needs_work → needs_review 
#29171 is removing the package, so this ticket can be closed
comment:13 Changed 2 years ago by
Status:  needs_review → positive_review 

comment:14 Changed 2 years ago by
Branch:  u/mkoeppe/add_ipywidgets_as_a_dependency_to_packages_using_the_sage_doctester 

Commit:  813bbf72f67e9d48ca41df5ff1efed1cd8013736 
Resolution:  → invalid 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
build/pkgs/numpy/patches/16871.patch: New
Update numpy to 1.19.1, add patches
Merge branch 'u/mkoeppe/upgrade_cython_to_0_29_20' of git://trac.sagemath.org/sage into t/29766/packages/networkx24
Merge branch 't/29929/tox_ini__add_a_macos_environment_without_homebrew__conda' into t/29766/packages/networkx24
right place for warnings.filterwarnings() for networkx & scipy
build/pkgs/scipy: Update to 1.5.2
build/make/Makefile.in: Improve handling of SAGE_CHECK_PACKAGES
build/make/Makefile.in: Handle the case in which SAGE_CHECK_PACKAGES is set using a command argument
Merge branch 't/29766/packages/networkx24' into t/30324/add_ipywidgets_as_a_dependency_to_packages_using_the_sage_doctester
build/pkgs/giacpy_sage/dependencies: Add ipywidgets if SAGE_CHECK!=no