Opened 2 years ago

Closed 2 years ago

#30324 closed defect (invalid)

Add ipywidgets as a dependency to packages using the sage doctester

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: optional Keywords:
Cc: slelievre, fbissey, frederichan Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #29766 Stopgaps:

Status badges

Description

Follow-up from #29426:

Currently giacpy_sage tests fail (https://github.com/mkoeppe/sage/runs/959684347) because its sage-check needs the sage doctester

Change History (14)

comment:1 Changed 2 years ago by mkoeppe

Dependencies: #29766

comment:2 Changed 2 years ago by mkoeppe

Branch: u/mkoeppe/add_ipywidgets_as_a_dependency_to_packages_using_the_sage_doctester

comment:3 Changed 2 years ago by mkoeppe

Commit: 4ddcc6fa71ba001bef34162462adde613e00eb2a
Reviewers: https://github.com/mkoeppe/sage/actions/runs/201918837

Last 10 new commits:

3558737build/pkgs/numpy/patches/16871.patch: New
1bf6249Update numpy to 1.19.1, add patches
061e975Merge branch 'u/mkoeppe/upgrade_cython_to_0_29_20' of git://trac.sagemath.org/sage into t/29766/packages/networkx24
fc7592cMerge branch 't/29929/tox_ini__add_a_macos_environment_without_homebrew__conda' into t/29766/packages/networkx24
7fe5985right place for warnings.filterwarnings() for networkx & scipy
5fa0bbabuild/pkgs/scipy: Update to 1.5.2
3890e1abuild/make/Makefile.in: Improve handling of SAGE_CHECK_PACKAGES
5d4b013build/make/Makefile.in: Handle the case in which SAGE_CHECK_PACKAGES is set using a command argument
b65f563Merge branch 't/29766/packages/networkx24' into t/30324/add_ipywidgets_as_a_dependency_to_packages_using_the_sage_doctester
4ddcc6fbuild/pkgs/giacpy_sage/dependencies: Add ipywidgets if SAGE_CHECK!=no

comment:4 Changed 2 years ago by mkoeppe

Status: newneeds_review

comment:5 Changed 2 years ago by git

Commit: 4ddcc6fa71ba001bef34162462adde613e00eb2a813bbf72f67e9d48ca41df5ff1efed1cd8013736

Branch pushed to git repo; I updated commit sha1. New commits:

813bbf7build/pkgs/giacpy_sage/dependencies: Fixup: Need SAGERUNTIME for installing

comment:6 Changed 2 years ago by mkoeppe

Reviewers: https://github.com/mkoeppe/sage/actions/runs/201918837github.com/mkoeppe/sage/actions/runs/202669190

comment:7 Changed 2 years ago by mkoeppe

Cc: fbissey frederichan added

comment:8 Changed 2 years ago by mkoeppe

This conflicts with #29171, of course

comment:9 Changed 2 years ago by mkoeppe

debian-stretch-maximal (https://github.com/mkoeppe/sage/runs/967227907)

Running the test suite for giacpy_sage-0.6.8...
...
    from .widgets_sagenb import (input_box, text_control, slider,
  File "/sage/local/lib/python3.7/site-packages/sage/repl/ipython_kernel/widgets_sagenb.py", line 30, in <module>
    from ipywidgets.widgets import (IntSlider, IntRangeSlider, FloatSlider,
ModuleNotFoundError: No module named 'ipywidgets'

comment:10 Changed 2 years ago by mkoeppe

... and I thought I had fixed the SAGE_CHECK_... business in #29766...

comment:11 Changed 2 years ago by mkoeppe

Status: needs_reviewneeds_work

comment:12 Changed 2 years ago by mkoeppe

Authors: Matthias Koeppe
Milestone: sage-9.2sage-duplicate/invalid/wontfix
Reviewers: github.com/mkoeppe/sage/actions/runs/202669190
Status: needs_workneeds_review

#29171 is removing the package, so this ticket can be closed

comment:13 Changed 2 years ago by slelievre

Status: needs_reviewpositive_review

comment:14 Changed 2 years ago by slelievre

Branch: u/mkoeppe/add_ipywidgets_as_a_dependency_to_packages_using_the_sage_doctester
Commit: 813bbf72f67e9d48ca41df5ff1efed1cd8013736
Resolution: invalid
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.