Opened 2 years ago

Closed 2 years ago

#30322 closed enhancement (fixed)

Deprecate import of classes Sigma, Euler_Phi, Moebius to the global namespace

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-9.2
Component: symbolics Keywords:
Cc: gh-DaveWitteMorris, slelievre, chapoton Merged in:
Authors: Matthias Koeppe Reviewers: Markus Wageringel
Report Upstream: N/A Work issues:
Branch: 4b8d207 (Commits, GitHub, GitLab) Commit: 4b8d207c9ab98019c8cfe74d74fbc9226aa70d6c
Dependencies: Stopgaps:

Status badges

Description

They are classes that implement the global functions sigma, euler_phi, moebius. There is no reason why the classes also need to be in the global namespace.

In this ticket, we deprecate the import.

Change History (8)

comment:1 Changed 2 years ago by mkoeppe

  • Branch set to u/mkoeppe/deprecate_import_of_classes_sigma__euler_phi__moebius_to_the_global_namespace

comment:2 Changed 2 years ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to c1ad4e2d28dbb47154e93ecd96da943a887b88be
  • Status changed from new to needs_review

New commits:

​c1ad4e2sage.arith.all: Deprecate import of classes Sigma, Euler_Phi, Moebius to the global namespace

comment:3 Changed 2 years ago by gh-mwageringel

  • Reviewers set to Markus Wageringel
  • Status changed from needs_review to needs_work

Some doctests are failing.

comment:4 Changed 2 years ago by git

  • Commit changed from c1ad4e2d28dbb47154e93ecd96da943a887b88be to 4b8d207c9ab98019c8cfe74d74fbc9226aa70d6c

Branch pushed to git repo; I updated commit sha1. New commits:

​4b8d207Replace uses of deprecated imports Euler_Phi, Moebius

comment:5 Changed 2 years ago by mkoeppe

  • Status changed from needs_work to needs_review

comment:6 Changed 2 years ago by gh-mwageringel

  • Status changed from needs_review to positive_review

comment:7 Changed 2 years ago by mkoeppe

Thanks!

comment:8 Changed 2 years ago by vbraun

  • Branch changed from u/mkoeppe/deprecate_import_of_classes_sigma__euler_phi__moebius_to_the_global_namespace to 4b8d207c9ab98019c8cfe74d74fbc9226aa70d6c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.