Opened 22 months ago

Closed 22 months ago

#30314 closed defect (fixed)

p-adic nth-root fails for some extensions

Reported by: alexjbest Owned by:
Priority: major Milestone: sage-9.2
Component: padics Keywords: padics, root
Cc: edgarcosta, gh-rbommel Merged in:
Authors: Alex J. Best Reviewers: Edgar Costa
Report Upstream: N/A Work issues:
Branch: 3f643b7 (Commits, GitHub, GitLab) Commit: 3f643b7336a9b4e900c470815f00cdcb06b37b7f
Dependencies: Stopgaps:

Status badges

Description

The following fails 

sage: K = Qp(29)
sage: x = polygen(K)
sage: L.<a> = K.extension(x^2 -29)
sage: L(4).nth_root(2)

due to the fact that _primitive_qth_root_of_unity(v) returns Nones when v is 0.

Change History (6)

comment:1 Changed 22 months ago by alexjbest

  • Branch set to u/alexjbest/padic-rootfix

comment:2 Changed 22 months ago by alexjbest

  • Commit set to 3f643b7336a9b4e900c470815f00cdcb06b37b7f
  • Status changed from new to needs_review

New commits:

​3f643b7fix bug in nth_root

comment:3 Changed 22 months ago by edgarcosta

  • Status changed from needs_review to positive_review

comment:4 Changed 22 months ago by mkoeppe

reviewer name

comment:5 Changed 22 months ago by edgarcosta

  • Reviewers set to Edgar Costa

comment:6 Changed 22 months ago by vbraun

  • Branch changed from u/alexjbest/padic-rootfix to 3f643b7336a9b4e900c470815f00cdcb06b37b7f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.