Opened 2 years ago
Closed 18 months ago
#30311 closed enhancement (fixed)
Immutability of Scalar Fields II
Reported by:  Michael Jung  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  manifolds  Keywords:  immutability 
Cc:  Eric Gourgoulhon, Travis Scrimshaw, Matthias Köppe  Merged in:  
Authors:  Michael Jung  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  6f39d6e (Commits, GitHub, GitLab)  Commit:  6f39d6eef2959ceaa637ea9f4c12cdc7c7b4b6d5 
Dependencies:  #30266, #30310, #30181  Stopgaps: 
Description (last modified by )
Immutability of scalar fields, see #30261.
Pass immutability to chart functions bound to scalar fields.
Change History (16)
comment:1 Changed 2 years ago by
Branch:  → u/ghmjungmath/immutability_of_scalar_fields_ii 

comment:2 Changed 2 years ago by
Authors:  → Michael Jung 

Cc:  Eric Gourgoulhon Travis Scrimshaw Matthias Köppe added 
Commit:  → 958ad16b7f62fb4528ea670f0d52efad985e2677 
Description:  modified (diff) 
Keywords:  immutability added 
Status:  new → needs_review 
comment:3 Changed 2 years ago by
Dependencies:  → #30266, #30310 

comment:4 Changed 2 years ago by
Dependencies:  #30266, #30310 → #30266, #30310, #30181 

comment:5 Changed 2 years ago by
Type:  PLEASE CHANGE → enhancement 

comment:6 Changed 2 years ago by
Component:  PLEASE CHANGE → manifolds 

comment:7 Changed 2 years ago by
Status:  needs_review → needs_work 

comment:8 Changed 2 years ago by
Milestone:  sage9.2 → sage9.3 

comment:9 Changed 23 months ago by
Commit:  958ad16b7f62fb4528ea670f0d52efad985e2677 → 6f39d6eef2959ceaa637ea9f4c12cdc7c7b4b6d5 

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
7247620  Merge branch 'develop' into t/30310/immutability_of_chart_functions

5ecbf3a  Trac #31181: return added

8b20fc4  Merge branch 't/31181/mutability_class_does_not_return_is_immutable' into t/30310/immutability_of_chart_functions

4c33935  Trac #31196: minor code improvements, py3 compatibility, documentation improved

e5228d3  Trac #31196: cpdef require methods + example added

d957f73  Trac #31196: unnecessary line in docstring removed

d6d6ba4  Trac #31182: __getstate__ and __setstate__

6cbd1fd  Trac #31182: doctests added for __setstate__ and __getstate__

848e96b  Merge branch 't/31182/mutability_class_and_pickling' into t/30310/immutability_of_chart_functions

6f39d6e  Trac #30311: apply set_immutable to all chart functions

comment:10 Changed 23 months ago by
Status:  needs_work → needs_review 

comment:11 Changed 23 months ago by
Should be a green patchbot (startup time fails).
By the way: Why does the startup time fail so often? What's going on there?
comment:12 Changed 23 months ago by
That is a bit fickle of a test. I wouldn't pay too much attention to it, but it is good to check it quickly to see if there is something causing a major slowdown on startup.
comment:13 Changed 21 months ago by
Milestone:  sage9.3 → sage9.4 

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.
comment:15 Changed 20 months ago by
Reviewers:  → Travis Scrimshaw 

Status:  needs_review → positive_review 
Yep, LGTM.
comment:16 Changed 18 months ago by
Branch:  u/ghmjungmath/immutability_of_scalar_fields_ii → 6f39d6eef2959ceaa637ea9f4c12cdc7c7b4b6d5 

Resolution:  → fixed 
Status:  positive_review → closed 
Last 10 new commits:
Trac #30266: Merge branch 't/30116/test_comparison_tensorfield' into t/30266/immutability_for_scalar_fields
Trac #30266: hash compatibility check wrt #30116
Trac #30266: Merge branch 'develop' into t/30266/immutability_for_scalar_fields
Trac 30266: hash function slightly improved
Trac #30266: remove dependency of #30116
Trac #30266: if statement missing
Merge branch 't/30181/immutable_elements_of_freemoduletensor' into t/30310/immutability_of_chart_functions
Trac #30310: immutability of chart functions
Merge branch 't/30310/immutability_of_chart_functions' into t/30311/immutability_of_scalar_fields_ii
Trac 30311: apply set_immutable to chart functions