Opened 15 months ago

Closed 5 months ago

#30311 closed enhancement (fixed)

Immutability of Scalar Fields II

Reported by: gh-mjungmath Owned by:
Priority: major Milestone: sage-9.4
Component: manifolds Keywords: immutability
Cc: egourgoulhon, tscrim, mkoeppe Merged in:
Authors: Michael Jung Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6f39d6e (Commits, GitHub, GitLab) Commit: 6f39d6eef2959ceaa637ea9f4c12cdc7c7b4b6d5
Dependencies: #30266, #30310, #30181 Stopgaps:

Status badges

Description (last modified by gh-mjungmath)

Immutability of scalar fields, see #30261.

Pass immutability to chart functions bound to scalar fields.

Change History (16)

comment:1 Changed 15 months ago by gh-mjungmath

  • Branch set to u/gh-mjungmath/immutability_of_scalar_fields_ii

comment:2 Changed 15 months ago by gh-mjungmath

  • Authors set to Michael Jung
  • Cc egourgoulhon tscrim mkoeppe added
  • Commit set to 958ad16b7f62fb4528ea670f0d52efad985e2677
  • Description modified (diff)
  • Keywords immutability added
  • Status changed from new to needs_review

Last 10 new commits:

055d226Trac #30266: Merge branch 't/30116/test_comparison_tensorfield' into t/30266/immutability_for_scalar_fields
8ca8b75Trac #30266: hash compatibility check wrt #30116
0bf9f36Trac #30266: Merge branch 'develop' into t/30266/immutability_for_scalar_fields
a5f6a19Trac 30266: hash function slightly improved
37b0042Trac #30266: remove dependency of #30116
2f72e19Trac #30266: if statement missing
8600c2dMerge branch 't/30181/immutable_elements_of_freemoduletensor' into t/30310/immutability_of_chart_functions
76229bdTrac #30310: immutability of chart functions
48a35b1Merge branch 't/30310/immutability_of_chart_functions' into t/30311/immutability_of_scalar_fields_ii
958ad16Trac 30311: apply set_immutable to chart functions

comment:3 Changed 15 months ago by gh-mjungmath

  • Dependencies set to #30266, #30310

comment:4 Changed 15 months ago by gh-mjungmath

  • Dependencies changed from #30266, #30310 to #30266, #30310, #30181

comment:5 Changed 15 months ago by gh-mjungmath

  • Type changed from PLEASE CHANGE to enhancement

comment:6 Changed 15 months ago by gh-mjungmath

  • Component changed from PLEASE CHANGE to manifolds

comment:7 Changed 14 months ago by gh-mjungmath

  • Status changed from needs_review to needs_work

comment:8 Changed 14 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:9 Changed 9 months ago by git

  • Commit changed from 958ad16b7f62fb4528ea670f0d52efad985e2677 to 6f39d6eef2959ceaa637ea9f4c12cdc7c7b4b6d5

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

7247620Merge branch 'develop' into t/30310/immutability_of_chart_functions
5ecbf3aTrac #31181: return added
8b20fc4Merge branch 't/31181/mutability_class_does_not_return_is_immutable' into t/30310/immutability_of_chart_functions
4c33935Trac #31196: minor code improvements, py3 compatibility, documentation improved
e5228d3Trac #31196: cpdef require methods + example added
d957f73Trac #31196: unnecessary line in docstring removed
d6d6ba4Trac #31182: __getstate__ and __setstate__
6cbd1fdTrac #31182: doctests added for __setstate__ and __getstate__
848e96bMerge branch 't/31182/mutability_class_and_pickling' into t/30310/immutability_of_chart_functions
6f39d6eTrac #30311: apply set_immutable to all chart functions

comment:10 Changed 9 months ago by gh-mjungmath

  • Status changed from needs_work to needs_review

comment:11 Changed 9 months ago by gh-mjungmath

Should be a green patchbot (startup time fails).

By the way: Why does the startup time fail so often? What's going on there?

comment:12 Changed 9 months ago by tscrim

That is a bit fickle of a test. I wouldn't pay too much attention to it, but it is good to check it quickly to see if there is something causing a major slowdown on startup.

comment:13 Changed 7 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:14 Changed 6 months ago by gh-mjungmath

Can we consider this ticket as done? Travis, Eric?

comment:15 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Yep, LGTM.

comment:16 Changed 5 months ago by vbraun

  • Branch changed from u/gh-mjungmath/immutability_of_scalar_fields_ii to 6f39d6eef2959ceaa637ea9f4c12cdc7c7b4b6d5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.