Opened 2 years ago
Closed 2 years ago
#30292 closed defect (fixed)
is_pyramid returns a wrong certificate
Reported by: | gh-LaisRast | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-9.2 |
Component: | geometry | Keywords: | polytope, combinatorialpolyhedron, is_pyramid |
Cc: | jipilab, gh-kliem | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | 4c5c730 (Commits, GitHub, GitLab) | Commit: | 4c5c730e216d0d160408d2474adcc51b33d28075 |
Dependencies: | Stopgaps: |
Description
The method is_pyramid
of CombinatorialPolyhedron
returns a wrong certificate:
sage: Polyhedron([[0, -1, -1], [0, -1, 1], [0, 1, -1], [0, 1, 1], [1, 0, 0]]).is_pyramid(certificate=True) (True, A vertex at (0, -1, -1))
This bug introduced in #29189; the indexing in _face_iter(True, 0)
is different from the indexing in Vrepresentation
.
Change History (8)
comment:1 Changed 2 years ago by
comment:2 Changed 2 years ago by
- Branch set to public/30292
- Commit set to fb22b485e74152bc740eeb577eb1f90413eca342
- Status changed from new to needs_review
New commits:
fb22b48 | fix certificate for pyramid
|
comment:3 Changed 2 years ago by
Perhaps there should be a _test... method that checks the certificate?
comment:4 Changed 2 years ago by
- Commit changed from fb22b485e74152bc740eeb577eb1f90413eca342 to 4c5c730e216d0d160408d2474adcc51b33d28075
Branch pushed to git repo; I updated commit sha1. New commits:
4c5c730 | add method `_test_pyramid`
|
comment:5 Changed 2 years ago by
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
comment:6 Changed 2 years ago by
- Priority changed from major to critical
comment:7 Changed 2 years ago by
Thank you.
comment:8 Changed 2 years ago by
- Branch changed from public/30292 to 4c5c730e216d0d160408d2474adcc51b33d28075
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Thanks for catching this. Stupid mistake.