#30288 closed enhancement (fixed)
Immutability for Sections
Reported by: | gh-mjungmath | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | manifolds | Keywords: | immutable |
Cc: | egourgoulhon, tscrim, mkoeppe | Merged in: | |
Authors: | Michael Jung | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | 04085f9 (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description (last modified by )
Change History (10)
comment:1 Changed 22 months ago by
- Branch set to u/gh-mjungmath/immutability_for_sections
comment:2 Changed 22 months ago by
- Cc egourgoulhon tscrim mkoeppe added
- Commit set to 7a9feb613d60eca7b431b9068dd87d8668dc3b0e
- Description modified (diff)
- Keywords immutable added
- Status changed from new to needs_review
comment:3 Changed 22 months ago by
- Commit changed from 7a9feb613d60eca7b431b9068dd87d8668dc3b0e to 04085f93853c301b0f8bfe59a0b831b513e39ed9
Branch pushed to git repo; I updated commit sha1. New commits:
04085f9 | Trac #30288: missing _is_zero attribute added
|
comment:4 Changed 22 months ago by
Green patchbot.
comment:5 Changed 22 months ago by
This looks fine except for the issue discussed in #30302
comment:6 Changed 22 months ago by
Still, this reflects the current state. I'd like to have it in because of unification. The copy modifications discussed in #30302 can then still be built upon this ticket.
comment:7 Changed 22 months ago by
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
comment:8 Changed 22 months ago by
Thanks! :)
comment:9 Changed 22 months ago by
- Branch changed from u/gh-mjungmath/immutability_for_sections to 04085f93853c301b0f8bfe59a0b831b513e39ed9
- Resolution set to fixed
- Status changed from positive_review to closed
comment:10 Changed 16 months ago by
- Commit 04085f93853c301b0f8bfe59a0b831b513e39ed9 deleted
- Description modified (diff)
Note: See
TracTickets for help on using
tickets.
New commits:
FreeModuleTensor, Vector: Subclass a new class ModuleElementWithMutability
sage.tensor.modules: Make all zero() and one() elements immutable
FreeModuleTensor: Replace special casing of the immutable zero by is_immutable
ModuleElementWithMutability.is_immutable, is_mutable: Change def to cpdef
Trac #30288: Merge branch 't/30181/immutable_elements_of_freemoduletensor' into t/30288/immutability_for_sections
Trac #30288: _is_zero attribute added + copy_from added + unsafe assignment added + immutability added