Opened 11 months ago

Closed 3 months ago

#30284 closed enhancement (fixed)

Immutability of Bundle Connections

Reported by: gh-mjungmath Owned by:
Priority: major Milestone: sage-9.3
Component: manifolds Keywords: immutability
Cc: egourgoulhon, tscrim, mkoeppe Merged in:
Authors: Michael Jung Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: 70a1d9a (Commits, GitHub, GitLab) Commit: 70a1d9adc329026d7a12bcfe40b648948b923fbd
Dependencies: #31181, #31182, #31215, #31273 Stopgaps:

Status badges

Description (last modified by gh-mjungmath)

Immutability of bundle connections. Furthermore, a copy method is added.

See #30261.

Change History (22)

comment:1 Changed 11 months ago by gh-mjungmath

  • Branch set to u/gh-mjungmath/immutability_of_bundle_connections

comment:2 Changed 11 months ago by gh-mjungmath

  • Authors set to Michael Jung
  • Cc egourgoulhon tscrim mkoeppe added
  • Commit set to ca3a9d78a8f6f4038fcf3ff7f63610bac13e6e57
  • Component changed from PLEASE CHANGE to manifolds
  • Dependencies set to #30208, #30209
  • Description modified (diff)
  • Keywords immutability added
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

Last 10 new commits:

d58d291Trac #30266: hash function condition + treatment of restrictions
061b89fTrac #30266: minor doctest improvement
5c7fd6eTrac #30266: immutability of restrictions + hash function improved
7ba0865Trac #30266: merge
0ec99d4Trac #30266: check by name
87fb411Trac #30266: ValueError replaced by AssertionError
43ec497Trac #30239: referenced before assignment error fixed
135ffd5Trac #30209: Merge branch 't/30239/tensorfield___call___alters_zero' into bundle_connection_change_of_frame
4d9209eTrac #30284: Merge branch 'bundle_connection_change_of_frame' into t/30284/immutability_of_bundle_connections
ca3a9d7Trac #30284: make bundle connections immutable + improved documentation

comment:3 Changed 11 months ago by git

  • Commit changed from ca3a9d78a8f6f4038fcf3ff7f63610bac13e6e57 to db3d290c986ce3773b0c6f1f4442b651d1b1ce79

Branch pushed to git repo; I updated commit sha1. New commits:

933c14aTrac #30209: Merge branch 'develop' into bundle_connection_change_of_frame
db3d290Trac #30284: Merge branch 'bundle_connection_change_of_frame' into t/30284/immutability_of_bundle_connections

comment:4 Changed 10 months ago by git

  • Commit changed from db3d290c986ce3773b0c6f1f4442b651d1b1ce79 to 25650ab8c70be4dcc6a9c9b2ae5c02b0165bb4db

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0685f7bTrac #30239: doctest fixed
e13b168Trac #30239: check by name for general tensor field action
4ff3431Trac #30239: try-finally instead of try-except
c1c74deRevert "Trac #30239: try-finally instead of try-except"
5cee80cTrac #30209: Merge branch 'bundle_connection_extension' into bundle_connection_action
21f2bd5Trac #30209: bundle connections acting on sections + vector fields
6cb7ff8Trac #30284: Merge branch 't/30209/bundle_connection_change_of_frame' into immutability_bundle_connection
cccf487Trac #30284: Merge branch 't/30274/immutability_of_tensor_fields' into immutability_bundle_connection
25650abTrac #30284: immutability bundle connection + copy method

comment:5 Changed 10 months ago by gh-mjungmath

  • Dependencies changed from #30208, #30209 to #30208, #30209, #30274
  • Description modified (diff)

comment:6 Changed 10 months ago by gh-mjungmath

  • Status changed from needs_review to needs_work

Branches diverged due to #30209. I will fix this as soon as #30209 has a positive review.

comment:7 Changed 9 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:8 Changed 5 months ago by gh-mjungmath

  • Dependencies changed from #30208, #30209, #30274 to #31181, #31182
  • Status changed from needs_work to needs_review

comment:9 Changed 5 months ago by git

  • Commit changed from 25650ab8c70be4dcc6a9c9b2ae5c02b0165bb4db to 8c2c4817d1671ebbf7b26e01159f83b8f7f8f70a

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1201f11Trac #30284: use Mutability mixin + copy method
8c2c481Trac #30284: __hash__ requires immutability

comment:10 Changed 5 months ago by git

  • Commit changed from 8c2c4817d1671ebbf7b26e01159f83b8f7f8f70a to deda20d4c4f11cb23dd08d97972f64b9734819dc

Branch pushed to git repo; I updated commit sha1. New commits:

deda20dTrac #30284: hash function improved

comment:11 Changed 5 months ago by gh-mjungmath

  • Description modified (diff)

comment:12 Changed 5 months ago by gh-mjungmath

  • Description modified (diff)

comment:13 Changed 5 months ago by gh-mjungmath

  • Dependencies changed from #31181, #31182 to #31181, #31182, #31215

comment:14 Changed 5 months ago by gh-mjungmath

  • Dependencies changed from #31181, #31182, #31215 to #31181, #31182, #31215, #31273

comment:15 Changed 5 months ago by git

  • Commit changed from deda20d4c4f11cb23dd08d97972f64b9734819dc to d5da6529d43fbc23378f3546fb34f7c4c58dfabf

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

e5228d3Trac #31196: cpdef require methods + example added
d957f73Trac #31196: unnecessary line in docstring removed
d6d6ba4Trac #31182: __getstate__ and __setstate__
6cbd1fdTrac #31182: doctests added for __setstate__ and __getstate__
9b8d52bMerge branch 't/31182/mutability_class_and_pickling' into immutability_of_bundle_connections
2ce59fbTrac #31215: assignment behavior better documented
dbc7946Merge branch 't/31215/bundle_connection_document_assignment_behavior' into immutability_of_bundle_connections
5381682Trac #31273: remove deprecated "form" input
999bd3eMerge branch 't/31273/remove_deprecated__form__input_for_bundle_connections' into immutability_of_bundle_connections
d5da652Trac #30284: mixin mutability module + improved hash

comment:16 Changed 5 months ago by git

  • Commit changed from d5da6529d43fbc23378f3546fb34f7c4c58dfabf to 70a1d9adc329026d7a12bcfe40b648948b923fbd

Branch pushed to git repo; I updated commit sha1. New commits:

70a1d9aTrac #30284: make connections immutable before usage of characteristic classes

comment:17 Changed 5 months ago by gh-mjungmath

Green patchbot.

comment:18 Changed 3 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:19 follow-up: Changed 3 months ago by gh-mjungmath

Travis, Eric, is that implementation fine or should I change something here? Patchbot is still green.

comment:20 in reply to: ↑ 19 Changed 3 months ago by egourgoulhon

  • Milestone changed from sage-9.4 to sage-9.3
  • Reviewers set to Eric Gourgoulhon
  • Status changed from needs_review to positive_review

Replying to gh-mjungmath:

Travis, Eric, is that implementation fine or should I change something here? Patchbot is still green.

The implementation seems fine. Sorry the delay in the review.

comment:21 Changed 3 months ago by gh-mjungmath

Thanks Eric! :)

comment:22 Changed 3 months ago by vbraun

  • Branch changed from u/gh-mjungmath/immutability_of_bundle_connections to 70a1d9adc329026d7a12bcfe40b648948b923fbd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.