Opened 2 years ago
Closed 17 months ago
#30284 closed enhancement (fixed)
Immutability of Bundle Connections
Reported by:  ghmjungmath  Owned by:  

Priority:  major  Milestone:  sage9.3 
Component:  manifolds  Keywords:  immutability 
Cc:  egourgoulhon, tscrim, mkoeppe  Merged in:  
Authors:  Michael Jung  Reviewers:  Eric Gourgoulhon 
Report Upstream:  N/A  Work issues:  
Branch:  70a1d9a (Commits, GitHub, GitLab)  Commit:  70a1d9adc329026d7a12bcfe40b648948b923fbd 
Dependencies:  #31181, #31182, #31215, #31273  Stopgaps: 
Description (last modified by )
Immutability of bundle connections. Furthermore, a copy
method is added.
See #30261.
Change History (22)
comment:1 Changed 2 years ago by
 Branch set to u/ghmjungmath/immutability_of_bundle_connections
comment:2 Changed 2 years ago by
 Cc egourgoulhon tscrim mkoeppe added
 Commit set to ca3a9d78a8f6f4038fcf3ff7f63610bac13e6e57
 Component changed from PLEASE CHANGE to manifolds
 Dependencies set to #30208, #30209
 Description modified (diff)
 Keywords immutability added
 Status changed from new to needs_review
 Type changed from PLEASE CHANGE to enhancement
comment:3 Changed 2 years ago by
 Commit changed from ca3a9d78a8f6f4038fcf3ff7f63610bac13e6e57 to db3d290c986ce3773b0c6f1f4442b651d1b1ce79
comment:4 Changed 2 years ago by
 Commit changed from db3d290c986ce3773b0c6f1f4442b651d1b1ce79 to 25650ab8c70be4dcc6a9c9b2ae5c02b0165bb4db
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
0685f7b  Trac #30239: doctest fixed

e13b168  Trac #30239: check by name for general tensor field action

4ff3431  Trac #30239: tryfinally instead of tryexcept

c1c74de  Revert "Trac #30239: tryfinally instead of tryexcept"

5cee80c  Trac #30209: Merge branch 'bundle_connection_extension' into bundle_connection_action

21f2bd5  Trac #30209: bundle connections acting on sections + vector fields

6cb7ff8  Trac #30284: Merge branch 't/30209/bundle_connection_change_of_frame' into immutability_bundle_connection

cccf487  Trac #30284: Merge branch 't/30274/immutability_of_tensor_fields' into immutability_bundle_connection

25650ab  Trac #30284: immutability bundle connection + copy method

comment:5 Changed 2 years ago by
 Dependencies changed from #30208, #30209 to #30208, #30209, #30274
 Description modified (diff)
comment:6 Changed 2 years ago by
 Status changed from needs_review to needs_work
comment:7 Changed 2 years ago by
 Milestone changed from sage9.2 to sage9.3
comment:8 Changed 19 months ago by
 Dependencies changed from #30208, #30209, #30274 to #31181, #31182
 Status changed from needs_work to needs_review
comment:9 Changed 19 months ago by
 Commit changed from 25650ab8c70be4dcc6a9c9b2ae5c02b0165bb4db to 8c2c4817d1671ebbf7b26e01159f83b8f7f8f70a
comment:10 Changed 19 months ago by
 Commit changed from 8c2c4817d1671ebbf7b26e01159f83b8f7f8f70a to deda20d4c4f11cb23dd08d97972f64b9734819dc
Branch pushed to git repo; I updated commit sha1. New commits:
deda20d  Trac #30284: hash function improved

comment:11 Changed 19 months ago by
 Description modified (diff)
comment:12 Changed 19 months ago by
 Description modified (diff)
comment:13 Changed 19 months ago by
 Dependencies changed from #31181, #31182 to #31181, #31182, #31215
comment:14 Changed 19 months ago by
 Dependencies changed from #31181, #31182, #31215 to #31181, #31182, #31215, #31273
comment:15 Changed 19 months ago by
 Commit changed from deda20d4c4f11cb23dd08d97972f64b9734819dc to d5da6529d43fbc23378f3546fb34f7c4c58dfabf
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
e5228d3  Trac #31196: cpdef require methods + example added

d957f73  Trac #31196: unnecessary line in docstring removed

d6d6ba4  Trac #31182: __getstate__ and __setstate__

6cbd1fd  Trac #31182: doctests added for __setstate__ and __getstate__

9b8d52b  Merge branch 't/31182/mutability_class_and_pickling' into immutability_of_bundle_connections

2ce59fb  Trac #31215: assignment behavior better documented

dbc7946  Merge branch 't/31215/bundle_connection_document_assignment_behavior' into immutability_of_bundle_connections

5381682  Trac #31273: remove deprecated "form" input

999bd3e  Merge branch 't/31273/remove_deprecated__form__input_for_bundle_connections' into immutability_of_bundle_connections

d5da652  Trac #30284: mixin mutability module + improved hash

comment:16 Changed 19 months ago by
 Commit changed from d5da6529d43fbc23378f3546fb34f7c4c58dfabf to 70a1d9adc329026d7a12bcfe40b648948b923fbd
Branch pushed to git repo; I updated commit sha1. New commits:
70a1d9a  Trac #30284: make connections immutable before usage of characteristic classes

comment:17 Changed 19 months ago by
Green patchbot.
comment:18 Changed 17 months ago by
 Milestone changed from sage9.3 to sage9.4
Setting new milestone based on a cursory review of ticket status, priority, and last modification date.
comment:19 followup: ↓ 20 Changed 17 months ago by
Travis, Eric, is that implementation fine or should I change something here? Patchbot is still green.
comment:20 in reply to: ↑ 19 Changed 17 months ago by
 Milestone changed from sage9.4 to sage9.3
 Reviewers set to Eric Gourgoulhon
 Status changed from needs_review to positive_review
Replying to ghmjungmath:
Travis, Eric, is that implementation fine or should I change something here? Patchbot is still green.
The implementation seems fine. Sorry the delay in the review.
comment:21 Changed 17 months ago by
Thanks Eric! :)
comment:22 Changed 17 months ago by
 Branch changed from u/ghmjungmath/immutability_of_bundle_connections to 70a1d9adc329026d7a12bcfe40b648948b923fbd
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
Trac #30266: hash function condition + treatment of restrictions
Trac #30266: minor doctest improvement
Trac #30266: immutability of restrictions + hash function improved
Trac #30266: merge
Trac #30266: check by name
Trac #30266: ValueError replaced by AssertionError
Trac #30239: referenced before assignment error fixed
Trac #30209: Merge branch 't/30239/tensorfield___call___alters_zero' into bundle_connection_change_of_frame
Trac #30284: Merge branch 'bundle_connection_change_of_frame' into t/30284/immutability_of_bundle_connections
Trac #30284: make bundle connections immutable + improved documentation