Opened 22 months ago
Closed 22 months ago
#30280 closed defect (fixed)
Immutability of Affine Connections
Reported by: | gh-mjungmath | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | manifolds | Keywords: | |
Cc: | Merged in: | ||
Authors: | Michael Jung | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | 28431c0 (Commits, GitHub, GitLab) | Commit: | 28431c0ca5b094e7e269125286ffba7338d43306 |
Dependencies: | #30285 | Stopgaps: |
Description (last modified by )
See #30261.
In this ticket, we introduce immutability to affine connections. Also, we fix the buggy hash
function.
Change History (25)
comment:1 Changed 22 months ago by
- Component changed from PLEASE CHANGE to manifolds
- Dependencies set to #30281
- Description modified (diff)
- Type changed from PLEASE CHANGE to defect
comment:2 Changed 22 months ago by
- Branch set to u/gh-mjungmath/immutability_of_affine_connections
comment:3 Changed 22 months ago by
- Commit set to c11d29ca935d3a4b3f60d0a250fc98236118f5f6
comment:4 Changed 22 months ago by
- Commit changed from c11d29ca935d3a4b3f60d0a250fc98236118f5f6 to 5156c5e1a28f7c3c78e3c638567fdcbd32a3f78c
Branch pushed to git repo; I updated commit sha1. New commits:
5156c5e | Trac #30280: Mutability inheritance removed + hash function improved
|
comment:5 Changed 22 months ago by
I have no idea what the problem was. Until this is resolved, I propose to remove the inheritance and implement the immutability manually, see last commit.
comment:6 Changed 22 months ago by
comment:7 Changed 22 months ago by
- Dependencies #30281 deleted
- Status changed from new to needs_review
comment:8 Changed 22 months ago by
- Commit changed from 5156c5e1a28f7c3c78e3c638567fdcbd32a3f78c to 20d31b32c281968092d81ac945de48d677285027
Branch pushed to git repo; I updated commit sha1. New commits:
20d31b3 | Trac #30280: removing __reduce__from mutability revert
|
comment:9 Changed 22 months ago by
- Commit changed from 20d31b32c281968092d81ac945de48d677285027 to b885ec8fe8a8eac2cb913addfc38e2be262d9860
Branch pushed to git repo; I updated commit sha1. New commits:
b885ec8 | Trac #30280: doctests fixed
|
comment:10 Changed 22 months ago by
- Dependencies set to #30285
comment:11 Changed 22 months ago by
- Commit changed from b885ec8fe8a8eac2cb913addfc38e2be262d9860 to 9d347f5456707c9a8538781fa1e7da6b37e04f24
comment:12 follow-up: ↓ 14 Changed 22 months ago by
I think it would be better to rebase it, removing the reverted commit and the reverting commit.
comment:13 Changed 22 months ago by
- Commit changed from 9d347f5456707c9a8538781fa1e7da6b37e04f24 to 920bb12550d79dce214d2b83aa1ce9bc34f2dbee
comment:14 in reply to: ↑ 12 Changed 22 months ago by
Replying to mkoeppe:
I think it would be better to rebase it, removing the reverted commit and the reverting commit.
Like this? I hope everything worked out during the rebase.
comment:15 Changed 22 months ago by
No, apparently not...I hate rebasing...
comment:16 Changed 22 months ago by
- Commit changed from 920bb12550d79dce214d2b83aa1ce9bc34f2dbee to 8e28ebca601c3ea3017b3af80bc022bbf860e0c1
Branch pushed to git repo; I updated commit sha1. New commits:
f0230f0 | Trac #30281: __reduce__ method removed
|
c11d29c | Trac #30280: immutability for affine connections
|
5156c5e | Trac #30280: Mutability inheritance removed + hash function improved
|
20d31b3 | Trac #30280: removing __reduce__from mutability revert
|
b885ec8 | Trac #30280: doctests fixed
|
3b1ef17 | Trac #30285: copy method added
|
9d347f5 | Trac #30280: copy method merged + documentation improved
|
8e28ebc | Merge commit '9d347f5456707' into t/30280/immutability_of_affine_connections
|
comment:17 Changed 22 months ago by
Damn it...
comment:18 Changed 22 months ago by
Can you fix this? Please? :-/
I don't even know what went wrong during the rebase. The last commit is somehow missing, but it shouldn't.
Then I messed it up by merging that last commit again. That was stupid.
comment:19 Changed 22 months ago by
Sure, let me take a look
comment:20 Changed 22 months ago by
Thank you! :)
comment:21 Changed 22 months ago by
- Branch changed from u/gh-mjungmath/immutability_of_affine_connections to u/mkoeppe/immutability_of_affine_connections
comment:22 Changed 22 months ago by
- Commit changed from 8e28ebca601c3ea3017b3af80bc022bbf860e0c1 to 28431c0ca5b094e7e269125286ffba7338d43306
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
New commits:
28431c0 | Trac #30280: immutability for affine connections
|
comment:23 Changed 22 months ago by
Thanks! May I ask how you did it?
comment:24 Changed 22 months ago by
I got really weird merge conflicts when trying to do git rebase -i
, so I just squashed everything on top of #30285 by doing git trac fetch 30285 && git reset FETCH_HEAD && git commit -a
.
comment:25 Changed 22 months ago by
- Branch changed from u/mkoeppe/immutability_of_affine_connections to 28431c0ca5b094e7e269125286ffba7338d43306
- Resolution set to fixed
- Status changed from positive_review to closed
Two things are strange here. First, the test suite starts a pickling test, that didn't happen before. Secondly, for some reason
is_immutable()
does not invoke properly. The doctests fail.I have uploaded my code. Can someone please take a short look?
New commits:
Trac #30281: __reduce__ method removed
Trac #30280: immutability for affine connections