Immutability of Affine Connections

[Michael Jung]

See #30261.

In this ticket, we introduce immutability to affine connections. Also, we fix the buggy hash function.

[Michael Jung]

Two things are strange here. First, the test suite starts a pickling test, that didn't happen before. Secondly, for some reason is_immutable() does not invoke properly. The doctests fail.

I have uploaded my code. Can someone please take a short look?

---

New commits:

​f0230f0	Trac #30281: __reduce__ method removed
​c11d29c	Trac #30280: immutability for affine connections

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​5156c5e

Trac #30280: Mutability inheritance removed + hash function improved

[Michael Jung]

I have no idea what the problem was. Until this is resolved, I propose to remove the inheritance and implement the immutability manually, see last commit.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​20d31b3

Trac #30280: removing __reduce__from mutability revert

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​b885ec8

Trac #30280: doctests fixed

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​3b1ef17	Trac #30285: copy method added
​9d347f5	Trac #30280: copy method merged + documentation improved

[Matthias Köppe]

I think it would be better to rebase it, removing the reverted commit and the reverting commit.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​6dfa1d0	Trac #30280: immutability for affine connections
​fc07910	Trac #30280: Mutability inheritance removed + hash function improved
​75b02c4	Trac #30280: doctests fixed
​920bb12	Trac #30285: copy method added

[Michael Jung]

Replying to mkoeppe:

I think it would be better to rebase it, removing the reverted commit and the reverting commit.

Like this? I hope everything worked out during the rebase.

[Michael Jung]

No, apparently not...I hate rebasing...

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​f0230f0	Trac #30281: __reduce__ method removed
​c11d29c	Trac #30280: immutability for affine connections
​5156c5e	Trac #30280: Mutability inheritance removed + hash function improved
​20d31b3	Trac #30280: removing __reduce__from mutability revert
​b885ec8	Trac #30280: doctests fixed
​3b1ef17	Trac #30285: copy method added
​9d347f5	Trac #30280: copy method merged + documentation improved
​8e28ebc	Merge commit '9d347f5456707' into t/30280/immutability_of_affine_connections

[Michael Jung]

Damn it...

[Michael Jung]

Can you fix this? Please? :-/

I don't even know what went wrong during the rebase. The last commit is somehow missing, but it shouldn't.

Then I messed it up by merging that last commit again. That was stupid.

[Matthias Köppe]

Sure, let me take a look

[Michael Jung]

Thank you! :)

[Matthias Köppe]

New commits:

​28431c0

Trac #30280: immutability for affine connections

[Michael Jung]

Thanks! May I ask how you did it?

[Matthias Köppe]

I got really weird merge conflicts when trying to do git rebase -i, so I just squashed everything on top of #30285 by doing git trac fetch 30285 && git reset FETCH_HEAD && git commit -a.