#30277 closed enhancement (fixed)

Remove src/module_list.py

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.2
Component: build Keywords:
Cc: dimpase, jhpalmieri Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: df38027 (Commits, GitHub, GitLab) Commit: df38027371870edf09f9e06fe1771d3cb2846aac
Dependencies: #29701, #29950 Stopgaps:

Status badges

Description

#29701 made this file obsolete. We remove it.

Change History (13)

comment:1 Changed 12 months ago by mkoeppe

  • Branch set to u/mkoeppe/remove_src_module_list_py

comment:2 Changed 12 months ago by mkoeppe

  • Commit set to 2818739c0b2088de9875683c6311f9a7685e4582
  • Dependencies changed from #29701 to #29701, #29950

Last 10 new commits:

08f5175Merge branch 'u/mkoeppe/change-src-bin-installation' of git://trac.sagemath.org/sage into t/29950/build_sagelib_using_installed_sage_setup
516358bbuild/pkgs/sagelib/src/tox.ini: Pass SAGE_LOCAL
5e577abMerge branch 't/29701/replace_use_of_module_list_optionalextension' into t/29950/build_sagelib_using_installed_sage_setup
eaced09build/pkgs/sagelib: Add remaining Python dependencies for sage.all
b8e366ebuild/pkgs/sagelib/spkg-src: chmod +x
0473ef3Merge branch 't/21559/change-src-bin-installation' into t/29950/build_sagelib_using_installed_sage_setup
7244371Merge branch 't/29701/replace_use_of_module_list_optionalextension' into t/29950/build_sagelib_using_installed_sage_setup
4344f89Merge branch 't/21559/change-src-bin-installation' into t/29950/build_sagelib_using_installed_sage_setup
01b96b0Merge branch 't/29701/replace_use_of_module_list_optionalextension' into t/29950/build_sagelib_using_installed_sage_setup
2818739Merge branch 't/29950/build_sagelib_using_installed_sage_setup' into t/30277/remove_src_module_list_py

comment:3 Changed 12 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc jhpalmieri added

comment:4 Changed 12 months ago by mkoeppe

  • Status changed from new to needs_review

comment:5 Changed 12 months ago by dimpase

it does not seem to work, all the pyx modules discovery is shot. Perhaps I have not rebuilt enough. Is a sagelib rebuild sufficient?

comment:6 Changed 12 months ago by dimpase

specifically, I cannot import src/sage/graphs/strongly_regular_db stuff

comment:7 Changed 12 months ago by dimpase

OK, after a rebuild from scratch I see one doctest failing:

sage -t --random-seed=0 src/sage_setup/find.py
**********************************************************************
File "src/sage_setup/find.py", line 215, in sage_setup.find.find_extra_files
Failed example:
    extras["sage/ext/interpreters"]
Expected:
    ['.../src/sage/ext/interpreters/wrapper_cdf.pxd', ...wrapper_cdf.h...]
Got:
    ['/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_rdf.pxd',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_cdf.pxd',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_rdf.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_cdf.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_cc.pxd',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_el.pxd',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_rr.pxd',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_cc.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_py.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_el.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_rr.pyx',
     '/home/scratch2/dimpase/sage/sage/src/sage/ext/interpreters/wrapper_py.pxd']
**********************************************************************
1 item had failures:
   1 of   7 in sage_setup.find.find_extra_files
    [36 tests, 1 failure, 0.73 s]

comment:8 Changed 12 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to needs_work

comment:9 Changed 12 months ago by dimpase

here are all the instances of wrapper_cdf.h I have:

$ find . -name wrapper_cdf.h
./local/lib/python3.7/site-packages/sage/ext/interpreters/wrapper_cdf.h
./build/pkgs/sagelib/src/build/lib.linux-x86_64-3.7/sage/ext/interpreters/wrapper_cdf.h
./build/pkgs/sagelib/src/build/cythonized/sage/ext/interpreters/wrapper_cdf.h

comment:10 Changed 12 months ago by git

  • Commit changed from 2818739c0b2088de9875683c6311f9a7685e4582 to df38027371870edf09f9e06fe1771d3cb2846aac

Branch pushed to git repo; I updated commit sha1. New commits:

8a19fe2build/make/Makefile.in (sagelib-clean): Clean the new build location
ccc67b0src/sage_setup: Update cythonized_dir in doctests
df38027Merge branch 't/29950/build_sagelib_using_installed_sage_setup' into t/30277/remove_src_module_list_py

comment:11 Changed 12 months ago by mkoeppe

  • Status changed from needs_work to needs_review

comment:12 Changed 12 months ago by dimpase

  • Status changed from needs_review to positive_review

ok

comment:13 Changed 12 months ago by vbraun

  • Branch changed from u/mkoeppe/remove_src_module_list_py to df38027371870edf09f9e06fe1771d3cb2846aac
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.