Opened 4 months ago

Closed 3 months ago

#30273 closed enhancement (fixed)

Add Ribbon and Mobile Poset examples

Reported by: gh-sgrosser Owned by:
Priority: major Milestone: sage-9.2
Component: combinatorics Keywords: gsoc2020 poset
Cc: tscrim Merged in:
Authors: Stefan Grosser Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3657d44 (Commits) Commit: 3657d44f461398635f64ebd3b44d8c6230245e1d
Dependencies: Stopgaps:

Description


Change History (14)

comment:1 Changed 4 months ago by gh-sgrosser

  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 4 months ago by gh-sgrosser

  • Branch set to u/gh-sgrosser/add_ribbon_and_mobile_poset_examples

comment:3 Changed 4 months ago by gh-sgrosser

  • Commit set to 3fbf3ed64e0f8b955dbacea12a8bab822c44dced
  • Component changed from PLEASE CHANGE to combinatorics

New commits:

edd63d5added slant sum and ribbon poset example
3fbf3edadded mobile and ribbon examples

comment:4 Changed 4 months ago by gh-sgrosser

  • Status changed from new to needs_review

comment:5 Changed 4 months ago by git

  • Commit changed from 3fbf3ed64e0f8b955dbacea12a8bab822c44dced to c49cd56b87f4e510feab6993579269e8b0851e07

Branch pushed to git repo; I updated commit sha1. New commits:

c49cd56corrected hangers to map to a list of posets

comment:6 Changed 4 months ago by git

  • Commit changed from c49cd56b87f4e510feab6993579269e8b0851e07 to 40e0eed06bc26f0d0182803246dc836d8fc938be

Branch pushed to git repo; I updated commit sha1. New commits:

40e0eedfixed docs

comment:7 Changed 4 months ago by git

  • Commit changed from 40e0eed06bc26f0d0182803246dc836d8fc938be to f061c6537682e52aae56359642e5a4e855a8c784

Branch pushed to git repo; I updated commit sha1. New commits:

f061c65remove whitespace

comment:8 Changed 4 months ago by git

  • Commit changed from f061c6537682e52aae56359642e5a4e855a8c784 to 4c1793d9dfcf96af65e59ff0b3ee9ca4476464a8

Branch pushed to git repo; I updated commit sha1. New commits:

4c1793dmade unique label names unnecessary

comment:9 Changed 4 months ago by git

  • Commit changed from 4c1793d9dfcf96af65e59ff0b3ee9ca4476464a8 to 6d63d481dac7ce05da15fbe240a6a4dfe36c6fba

Branch pushed to git repo; I updated commit sha1. New commits:

6d63d48optimized example to not relabel the passed posets

comment:10 Changed 4 months ago by tscrim

Can you also add a doctest without an anchor?

comment:11 Changed 4 months ago by git

  • Commit changed from 6d63d481dac7ce05da15fbe240a6a4dfe36c6fba to dd65e10a766b685ea72c09f418549cc76a8b9171

Branch pushed to git repo; I updated commit sha1. New commits:

dd65e10fixed an anchor issue and added a second doctest using anchor

comment:12 Changed 4 months ago by git

  • Commit changed from dd65e10a766b685ea72c09f418549cc76a8b9171 to 3657d44f461398635f64ebd3b44d8c6230245e1d

Branch pushed to git repo; I updated commit sha1. New commits:

8c69f1achanged docstrings
3657d44Added examples to the table above

comment:13 Changed 4 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:14 Changed 3 months ago by vbraun

  • Branch changed from u/gh-sgrosser/add_ribbon_and_mobile_poset_examples to 3657d44f461398635f64ebd3b44d8c6230245e1d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.