Opened 9 months ago

Closed 8 months ago

#30260 closed enhancement (fixed)

Graphs: more distance-regular graphs

Reported by: gh-Ivo-Maffei Owned by:
Priority: major Milestone: sage-9.2
Component: graph theory Keywords: drg
Cc: dimpase Merged in:
Authors: Ivo Maffei Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: a87fad1 (Commits, GitHub, GitLab) Commit: a87fad1a74954c825c13ba6065dc275d1417cb42
Dependencies: #30240 Stopgaps:

Status badges

Description

Added a few more constructions of distance-regular graphs

Change History (10)

comment:1 Changed 9 months ago by gh-Ivo-Maffei

  • Branch set to public/graphs/30260
  • Cc dimpase added
  • Commit set to e253cb49e52ac8a53dcfb60134282ccb817bf85d
  • Dependencies set to #30240
  • Status changed from new to needs_review

comment:2 Changed 9 months ago by git

  • Commit changed from e253cb49e52ac8a53dcfb60134282ccb817bf85d to 102bb916575d314a29b134e200eeb6d6d7cec740

Branch pushed to git repo; I updated commit sha1. New commits:

​bc19673change optional flag for atlasrep
​12d3e1erenamed locally GQ function and added references
​e91e058forgot to rename graph
​6317708fixed indentation issue
​3fc6db5merged drg_sporadic1
​102bb91added reference blocks

comment:3 Changed 9 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

looks good to me.

comment:4 Changed 9 months ago by mkoeppe

  • Status changed from positive_review to needs_work

see ​https://trac.sagemath.org/ticket/29701#comment:61

comment:5 Changed 9 months ago by git

  • Commit changed from 102bb916575d314a29b134e200eeb6d6d7cec740 to 9db5fd3ab5df8c3cffed39c49bdb7e08b5e614ff

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

​1978c7dadded a few sporadic distance regular graphs
​384fb27moved file to generators; fixed tests
​85b4d55added 4 more sporadic drg
​4c4f69badded remaining Witt graphs
​9c81329renamed locally GQ function and added references
​b88df6badded reference blocks
​ecde7cafix wrong rebase merge conflict resolution
​e063b5esimplified import
​574960dadded gap_packages flag to atlasrep
​9db5fd3Merge branch 'drg_sporadic1' into drg_sporadic2

comment:6 Changed 9 months ago by git

  • Commit changed from 9db5fd3ab5df8c3cffed39c49bdb7e08b5e614ff to a87fad1a74954c825c13ba6065dc275d1417cb42

Branch pushed to git repo; I updated commit sha1. New commits:

​a87fad1added gap_packages flag to atlasrep

comment:7 Changed 9 months ago by gh-Ivo-Maffei

  • Status changed from needs_work to needs_review

I rebased and merged all changes to #30240. Now this ticket should work without module_list.py

comment:8 Changed 9 months ago by mkoeppe

Thanks for fixing it!

comment:9 Changed 8 months ago by dimpase

  • Status changed from needs_review to positive_review

LGTM

comment:10 Changed 8 months ago by vbraun

  • Branch changed from public/graphs/30260 to a87fad1a74954c825c13ba6065dc275d1417cb42
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.