Changes between Version 1 and Version 2 of Ticket #30241, comment 4


Ignore:
Timestamp:
07/28/20 19:12:41 (6 months ago)
Author:
gh-mjungmath
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30241, comment 4

    v1 v2  
    99Either way, I agree that consistency is desirable here.
    1010
    11 Allow me a side note: please remember that the whole manifold setup is built upon `FiniteRankFreeModule`. Modifying substatial things here might cause problems in the manifold implementation. It would be good to double check and, if absolutely necessary, make changes there, too.
     11Allow me a side note: please remember that the whole manifold setup is built upon `FiniteRankFreeModule`. Modifying substatial things here might cause problems in the manifold implementation. It would be good to double check and, if absolutely necessary, make changes there, too. Henceforth, I suggest doctesting the manifold part, too.