Changes between Initial Version and Version 1 of Ticket #30241, comment 4


Ignore:
Timestamp:
07/28/20 19:09:03 (2 years ago)
Author:
gh-mjungmath
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30241, comment 4

    initial v1  
    77Fair point. Then I would vote for changing this to the expected outputs rather than creating a whole new class which has no further purpose than everything that is already there. Regarding Travis [https://trac.sagemath.org/ticket/30169#comment:10 comment:10] this would be a convenient solution. Meaning: `M.exterior_power(1)` should return an instance of `ExtPowerFreeModule` and `M.tensor_module(1, 0)` should return an instance of `TensorFreeModule`. Then, one can implement the isomorphisms.
    88
     9Either way, I agree that consistency is desirable here.
     10
    911Allow me a side note: please remember that the whole manifold setup is built upon `FiniteRankFreeModule`. Modifying substatial things here might cause problems in the manifold implementation. It would be good to double check and, if absolutely necessary, make changes there, too.