Opened 7 months ago
Closed 7 months ago
#30228 closed enhancement (fixed)
Declare Sections with Name only
Reported by: | gh-mjungmath | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | manifolds | Keywords: | |
Cc: | egourgoulhon, tscrim | Merged in: | |
Authors: | Michael Jung | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 78692a6 (Commits, GitHub, GitLab) | Commit: | 78692a6b4a712cbaf5f20b5f8199a529f9755be7 |
Dependencies: | Stopgaps: |
Description (last modified by )
At this stage we have the following difference between sections and tensor fields:
sage: M = Manifold(2, 'M', start_index=1) ....: X.<x,y> = M.chart() ....: E = M.vector_bundle(2, 'E') ....: e = E.local_frame('e') ....: v = M.vector_field('v') ....: s = E.section('s') Traceback (most recent call last) ... IndexError: string index out of range
This simply comes from the fact that the method section
does not like pure strings as input, in contrast to vector_field
or tensor
.
Change History (7)
comment:1 Changed 7 months ago by
- Description modified (diff)
comment:2 Changed 7 months ago by
- Branch set to u/gh-mjungmath/declare_sections_with_name_only
comment:3 Changed 7 months ago by
- Commit set to 490d38d93b1f75a3ca245f9c3add92c017f35d42
- Status changed from new to needs_review
comment:4 Changed 7 months ago by
- Description modified (diff)
comment:5 Changed 7 months ago by
- Commit changed from 490d38d93b1f75a3ca245f9c3add92c017f35d42 to 78692a6b4a712cbaf5f20b5f8199a529f9755be7
Branch pushed to git repo; I updated commit sha1. New commits:
78692a6 | Trac #30228: misleading comment corrected
|
comment:6 Changed 7 months ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:7 Changed 7 months ago by
- Branch changed from u/gh-mjungmath/declare_sections_with_name_only to 78692a6b4a712cbaf5f20b5f8199a529f9755be7
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Trac #30228: init comp with string