Opened 2 years ago

Closed 2 years ago

#30225 closed defect (fixed)

Fix deprecation warnings when unpickling pynac objects with Python 3.8

Reported by: Antonio Rojas Owned by:
Priority: major Milestone: sage-9.2
Component: packages: standard Keywords:
Cc: John Palmieri, Matthias Köppe Merged in:
Authors: Antonio Rojas Reviewers: Matthias Koeppe
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: ecc6f45 (Commits, GitHub, GitLab) Commit: ecc6f4591e6bebd8ce9b7505df6186aeacb6812c
Dependencies: Stopgaps:

Status badges

Description (last modified by Antonio Rojas)

With Python 3.8, unpickling pynac objects gives a deprecation warning

DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats

These are fixed in this ticket by defining PY_SSIZE_T_CLEAN where appropriate

Upstream pull request: https://github.com/pynac/pynac/pull/354

Change History (10)

comment:1 Changed 2 years ago by Antonio Rojas

Authors: Antonio Rojas
Cc: John Palmieri Matthias Köppe added
Description: modified (diff)
Report Upstream: N/AReported upstream. No feedback yet.
Status: newneeds_review
Type: PLEASE CHANGEdefect

comment:2 Changed 2 years ago by Antonio Rojas

Branch: u/arojas/fix_deprecation_warnings_when_unpickling_pynac_objects_with_python_3_8

comment:3 Changed 2 years ago by git

Commit: c4769bf150479ce66baac5f0f4d2a76aa7fa0a65

Branch pushed to git repo; I updated commit sha1. New commits:

c4769bfAdd pynac patch to fix deprecation warnings on unpickling with Python 3.8

comment:4 Changed 2 years ago by git

Commit: c4769bf150479ce66baac5f0f4d2a76aa7fa0a65ecc6f4591e6bebd8ce9b7505df6186aeacb6812c

Branch pushed to git repo; I updated commit sha1. New commits:

ecc6f45Add patch

comment:5 Changed 2 years ago by Antonio Rojas

Component: PLEASE CHANGEpackages: standard

comment:6 Changed 2 years ago by Matthias Köppe

Is this safe to apply also for earlier Python versions?

comment:7 Changed 2 years ago by Antonio Rojas

At least for 3.7 it seems so

comment:8 Changed 2 years ago by John Palmieri

Works for me with OS X and the system Python, version 3.7.3.

comment:9 Changed 2 years ago by Matthias Köppe

Reviewers: Matthias Koeppe
Status: needs_reviewpositive_review

comment:10 Changed 2 years ago by Volker Braun

Branch: u/arojas/fix_deprecation_warnings_when_unpickling_pynac_objects_with_python_3_8ecc6f4591e6bebd8ce9b7505df6186aeacb6812c
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.