Opened 2 years ago
Closed 2 years ago
#30212 closed defect (fixed)
Fix tkz-graph and tkz-berge links: altermundus.com is gone
Reported by: | slelievre | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | graph theory | Keywords: | beginner |
Cc: | slelievre | Merged in: | |
Authors: | David Coudert, Travis Scrimshaw | Reviewers: | François Bissey, Yuki Kanakubo, Benjamin Hackl, Reimundo Heluani |
Report Upstream: | N/A | Work issues: | |
Branch: | ae2af30 (Commits, GitHub, GitLab) | Commit: | ae2af30618fdc28e9befc00cea93aa2ccb2c4e57 |
Dependencies: | Stopgaps: |
Description
The _latex_
method of a graph checks for two LaTeX packages,
tkz-graph and tkz-berge. If not found, it prints a warning referring to
the "Altermundus" website. The LaTeX tutorial also refers to it.
The Altermundus website is gone, its tkz page is archived at:
The links should be updated to point to the relevant CTAN pages:
Change History (22)
comment:1 Changed 2 years ago by
comment:2 Changed 2 years ago by
- Branch set to public/30212_altermundus
- Commit set to f55fea1747901af2e0d21a3af45a4fdf0bd14050
- Status changed from new to needs_review
We need reviewers able to read English, French, German, Portuguese, and Japanese. Actually, for Japanese, we need also need someone able to write it.
New commits:
f55fea1 | trac #30212: correction for most languages
|
comment:3 Changed 2 years ago by
French and English OK for me, I cannot comment on other languages.
comment:4 Changed 2 years ago by
- Commit changed from f55fea1747901af2e0d21a3af45a4fdf0bd14050 to d1b1e308c0608ff2fc9d19c911c57cdcc897eefa
Branch pushed to git repo; I updated commit sha1. New commits:
d1b1e30 | trac #30212: minor corrections to german version
|
comment:5 Changed 2 years ago by
I slightly corrected the German version, English is fine -- and I cannot comment on the others. :-)
comment:6 Changed 2 years ago by
The Portuguese translation seems OK, according a Brazilian student of my team.
comment:7 Changed 2 years ago by
- Commit changed from d1b1e308c0608ff2fc9d19c911c57cdcc897eefa to f75fa4cbfef122a7816f38281bddb2ee690720ec
Branch pushed to git repo; I updated commit sha1. New commits:
f75fa4c | Updaing the latex portion of the Japanese tutorial.
|
comment:8 Changed 2 years ago by
Here is what I could do with the Japanese version. I will ask someone I know to double-check.
comment:9 Changed 2 years ago by
- Commit changed from f75fa4cbfef122a7816f38281bddb2ee690720ec to e3caf363c88f6b2aec5fc25696dca04beda5f850
Branch pushed to git repo; I updated commit sha1. New commits:
e3caf36 | More natural Japanese translation.
|
comment:10 Changed 2 years ago by
- Commit changed from e3caf363c88f6b2aec5fc25696dca04beda5f850 to 436b02094b2561eb3d3642f3b178f5fc3a6a291d
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
436b020 | More natural Japanese translation.
|
comment:11 Changed 2 years ago by
I had a native speaker friend of mine check the Japanese version. Now it is more natural.
comment:12 Changed 2 years ago by
Please add author and reviewer names as appropriate, and someone give this positive review.
comment:13 Changed 2 years ago by
- Reviewers set to François Bissey
added my name. Once other people have added the appropriate names we can switch to positive review.
comment:14 Changed 2 years ago by
- Reviewers changed from François Bissey to François Bissey, Yuki Kanakubo
comment:15 Changed 2 years ago by
We still need reviewer names for German and portuguese unless Travis can vouch for them.
comment:16 Changed 2 years ago by
I can only say the Portuguese seems right coming from my knowledge of Spanish. I would not rely on that however. ;)
comment:17 Changed 2 years ago by
- Reviewers changed from François Bissey, Yuki Kanakubo to François Bissey, Yuki Kanakubo, Reimundo Heluani
Reimundo Heluani validated the Portuguese version on sage-devel:
comment:18 follow-up: ↓ 19 Changed 2 years ago by
The German part looks correct, but difficult to understand.
There was a dash missing between PGF
and Bibliothek
. In German you cannot just put to nouns like this in row, but have to combine them (either as new word or with a dash). This might explain funny English spelling of German natives.
Do I see correctly that there is not hint here, how to get the PGF library? (It's probably somewhere else or obvious anyway).
-Um kombinatorische Graphen darstellen zu können, wird eine aktuelle -Version der PGF Bibliothek, die Datei ``tkz-graph.sty`` (verfügbar -via https://www.ctan.org/pkg/tkz-graph), sowie die Datei -``tkz-arith.sty`` und vielleicht auch ``tkz-berge.sty``, jeweils verfügbar -auf der Seite https://www.ctan.org/pkg/tkz-berge, benötigt. +Um kombinatorische Graphen darstellen zu können, +benötigt man eine aktuelle Version der PGF-Bibliothek, +die Datei ``tkz-graph.sty`` (verfügbar +unter https://www.ctan.org/pkg/tkz-graph), die Datei +``tkz-arith.sty`` und vielleicht auch ``tkz-berge.sty``, beide verfügbar +auf der Seite https://www.ctan.org/pkg/tkz-berge.
comment:19 in reply to: ↑ 18 Changed 2 years ago by
- Reviewers changed from François Bissey, Yuki Kanakubo, Reimundo Heluani to François Bissey, Yuki Kanakubo, Benjamin Hackl, Reimundo Heluani
Replying to gh-kliem:
The German part looks correct, but difficult to understand.
I like your simplified version more than mine as well. Would you push it?
Do I see correctly that there is not hint here, how to get the PGF library? (It's probably somewhere else or obvious anyway).
You are right. I don't think that it is necessary to give more details here; it is not so difficult to find information about pgf (in my opinion).
comment:20 Changed 2 years ago by
- Commit changed from 436b02094b2561eb3d3642f3b178f5fc3a6a291d to ae2af30618fdc28e9befc00cea93aa2ccb2c4e57
Branch pushed to git repo; I updated commit sha1. New commits:
ae2af30 | simpler German version
|
comment:21 Changed 2 years ago by
- Status changed from needs_review to positive_review
Thanks to all of you !
comment:22 Changed 2 years ago by
- Branch changed from public/30212_altermundus to ae2af30618fdc28e9befc00cea93aa2ccb2c4e57
- Resolution set to fixed
- Status changed from positive_review to closed
Which files need updating can be found out with this terminal command: