Opened 3 months ago

Closed 7 weeks ago

#30212 closed defect (fixed)

Fix tkz-graph and tkz-berge links: altermundus.com is gone

Reported by: slelievre Owned by:
Priority: major Milestone: sage-9.2
Component: graph theory Keywords: beginner
Cc: slelievre Merged in:
Authors: David Coudert, Travis Scrimshaw Reviewers: François Bissey, Yuki Kanakubo, Benjamin Hackl, Reimundo Heluani
Report Upstream: N/A Work issues:
Branch: ae2af30 (Commits) Commit: ae2af30618fdc28e9befc00cea93aa2ccb2c4e57
Dependencies: Stopgaps:

Description

The _latex_ method of a graph checks for two LaTeX packages, tkz-graph and tkz-berge. If not found, it prints a warning referring to the "Altermundus" website. The LaTeX tutorial also refers to it.

The Altermundus website is gone, its tkz page is archived at:

The links should be updated to point to the relevant CTAN pages:

Change History (22)

comment:1 Changed 3 months ago by slelievre

Which files need updating can be found out with this terminal command:

$ git grep -i "altermundus" src
src/doc/de/tutorial/latex.rst:und eventuell ``tkz-berge.sty`` benötigt, allesamt verfügbar auf der `Altermundus Seite
src/doc/de/tutorial/latex.rst:<http://altermundus.com/pages/graph.html>`_.
src/doc/en/tutorial/latex.rst:and perhaps ``tkz-berge.sty``, all from the `Altermundus site
src/doc/en/tutorial/latex.rst:<http://altermundus.com/pages/tkz/graph/>`_.
src/doc/fr/tutorial/latex.rst:``tkz-berge.sty``, tous issus du site web `Altermundus
src/doc/fr/tutorial/latex.rst:<http://www.altermundus.fr/pages/graph.html>`_ (`version anglaise
src/doc/fr/tutorial/latex.rst:<http://altermundus.com/pages/graph/>`_).
src/doc/ja/tutorial/latex.rst:tkz関係のファイルは全て `Altermundus site <http://altermundus.com/pages/tkz/graph/>`_ から入手することができる.
src/doc/pt/tutorial/latex.rst:talvez ``tkz-berge.sty``, que estão disponíveis em `Altermundus site
src/doc/pt/tutorial/latex.rst:<http://altermundus.com/pages/tkz/graph/>`_.
src/sage/graphs/graph_latex.py:``tkz-graph``, whose work can be found at his `Altermundus.com
src/sage/graphs/graph_latex.py:<http://altermundus.com/>`_ site.
src/sage/graphs/graph_latex.py:- tkz-graph: http://altermundus.com/pages/tkz/
src/sage/graphs/graph_latex.py:Visit 'http://altermundus.com/pages/tkz/'.
src/sage/graphs/graph_latex.py:Visit 'http://altermundus.com/pages/tkz/'.
src/sage/graphs/graph_latex.py:        `Altermundus.com <http://altermundus.com/>`_
src/sage/misc/latex.py:(LaTeX code taken from http://altermundus.com/pages/tkz/)

comment:2 Changed 8 weeks ago by dcoudert

  • Authors set to David Coudert
  • Branch set to public/30212_altermundus
  • Commit set to f55fea1747901af2e0d21a3af45a4fdf0bd14050
  • Status changed from new to needs_review

We need reviewers able to read English, French, German, Portuguese, and Japanese. Actually, for Japanese, we need also need someone able to write it.


New commits:

f55fea1trac #30212: correction for most languages

comment:3 Changed 7 weeks ago by fbissey

French and English OK for me, I cannot comment on other languages.

comment:4 Changed 7 weeks ago by git

  • Commit changed from f55fea1747901af2e0d21a3af45a4fdf0bd14050 to d1b1e308c0608ff2fc9d19c911c57cdcc897eefa

Branch pushed to git repo; I updated commit sha1. New commits:

d1b1e30trac #30212: minor corrections to german version

comment:5 Changed 7 weeks ago by behackl

I slightly corrected the German version, English is fine -- and I cannot comment on the others. :-)

comment:6 Changed 7 weeks ago by dcoudert

The Portuguese translation seems OK, according a Brazilian student of my team.

comment:7 Changed 7 weeks ago by git

  • Commit changed from d1b1e308c0608ff2fc9d19c911c57cdcc897eefa to f75fa4cbfef122a7816f38281bddb2ee690720ec

Branch pushed to git repo; I updated commit sha1. New commits:

f75fa4cUpdaing the latex portion of the Japanese tutorial.

comment:8 Changed 7 weeks ago by tscrim

Here is what I could do with the Japanese version. I will ask someone I know to double-check.

comment:9 Changed 7 weeks ago by git

  • Commit changed from f75fa4cbfef122a7816f38281bddb2ee690720ec to e3caf363c88f6b2aec5fc25696dca04beda5f850

Branch pushed to git repo; I updated commit sha1. New commits:

e3caf36More natural Japanese translation.

comment:10 Changed 7 weeks ago by git

  • Commit changed from e3caf363c88f6b2aec5fc25696dca04beda5f850 to 436b02094b2561eb3d3642f3b178f5fc3a6a291d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

436b020More natural Japanese translation.

comment:11 Changed 7 weeks ago by tscrim

I had a native speaker friend of mine check the Japanese version. Now it is more natural.

Last edited 7 weeks ago by tscrim (previous) (diff)

comment:12 Changed 7 weeks ago by slelievre

Please add author and reviewer names as appropriate, and someone give this positive review.

comment:13 Changed 7 weeks ago by fbissey

  • Reviewers set to François Bissey

added my name. Once other people have added the appropriate names we can switch to positive review.

comment:14 Changed 7 weeks ago by tscrim

  • Authors changed from David Coudert to David Coudert, Travis Scrimshaw
  • Reviewers changed from François Bissey to François Bissey, Yuki Kanakubo

comment:15 Changed 7 weeks ago by fbissey

We still need reviewer names for German and portuguese unless Travis can vouch for them.

comment:16 Changed 7 weeks ago by tscrim

I can only say the Portuguese seems right coming from my knowledge of Spanish. I would not rely on that however. ;)

comment:17 Changed 7 weeks ago by slelievre

  • Reviewers changed from François Bissey, Yuki Kanakubo to François Bissey, Yuki Kanakubo, Reimundo Heluani

Reimundo Heluani validated the Portuguese version on sage-devel:

comment:18 follow-up: Changed 7 weeks ago by gh-kliem

The German part looks correct, but difficult to understand.

There was a dash missing between PGF and Bibliothek. In German you cannot just put to nouns like this in row, but have to combine them (either as new word or with a dash). This might explain funny English spelling of German natives.

Do I see correctly that there is not hint here, how to get the PGF library? (It's probably somewhere else or obvious anyway).

-Um kombinatorische Graphen darstellen zu können, wird eine aktuelle
-Version der PGF Bibliothek, die Datei ``tkz-graph.sty`` (verfügbar
-via https://www.ctan.org/pkg/tkz-graph), sowie die Datei
-``tkz-arith.sty`` und vielleicht auch ``tkz-berge.sty``, jeweils verfügbar
-auf der Seite https://www.ctan.org/pkg/tkz-berge, benötigt.
+Um kombinatorische Graphen darstellen zu können,
+benötigt man eine aktuelle Version der PGF-Bibliothek,
+die Datei ``tkz-graph.sty`` (verfügbar
+unter https://www.ctan.org/pkg/tkz-graph), die Datei
+``tkz-arith.sty`` und vielleicht auch ``tkz-berge.sty``, beide verfügbar
+auf der Seite https://www.ctan.org/pkg/tkz-berge.

comment:19 in reply to: ↑ 18 Changed 7 weeks ago by behackl

  • Reviewers changed from François Bissey, Yuki Kanakubo, Reimundo Heluani to François Bissey, Yuki Kanakubo, Benjamin Hackl, Reimundo Heluani

Replying to gh-kliem:

The German part looks correct, but difficult to understand.

I like your simplified version more than mine as well. Would you push it?

Do I see correctly that there is not hint here, how to get the PGF library? (It's probably somewhere else or obvious anyway).

You are right. I don't think that it is necessary to give more details here; it is not so difficult to find information about pgf (in my opinion).

comment:20 Changed 7 weeks ago by git

  • Commit changed from 436b02094b2561eb3d3642f3b178f5fc3a6a291d to ae2af30618fdc28e9befc00cea93aa2ccb2c4e57

Branch pushed to git repo; I updated commit sha1. New commits:

ae2af30simpler German version

comment:21 Changed 7 weeks ago by dcoudert

  • Status changed from needs_review to positive_review

Thanks to all of you !

comment:22 Changed 7 weeks ago by vbraun

  • Branch changed from public/30212_altermundus to ae2af30618fdc28e9befc00cea93aa2ccb2c4e57
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.