Opened 2 years ago

Closed 6 weeks ago

#30207 closed enhancement (fixed)

Deprecate sage.misc.dist.install_scripts

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.7
Component: build Keywords: sd111
Cc: charpent, jhpalmieri, saraedum Merged in:
Authors: John Palmieri Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: c77ecb0 (Commits, GitHub, GitLab) Commit: c77ecb07a599287d5e6577fa87f1faf71bc5e6ef
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

This function does not belong into sagelib. If it is still needed at all, it should become a script in sage-the-distribution.

install_scripts is also mentioned in one place in the sage installation guide, src/doc/en/installation/source.rst. We update it.

​https://groups.google.com/d/msg/sage-devel/M6S1bL_qU3Y/twdtVp0rBgAJ

Change History (16)

comment:1 Changed 22 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:2 Changed 19 months ago by mkoeppe

  • Keywords sd111 added

Hoping we can make progress on this ticket this week - ​https://wiki.sagemath.org/days111

comment:3 Changed 15 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

comment:4 Changed 11 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5

comment:5 Changed 7 months ago by mkoeppe

  • Milestone changed from sage-9.5 to sage-9.6

comment:6 Changed 3 months ago by mkoeppe

  • Milestone changed from sage-9.6 to sage-9.7

comment:7 Changed 2 months ago by jhpalmieri

  • Branch set to u/jhpalmieri/deprecate-install-scripts

comment:8 follow-up: Changed 2 months ago by jhpalmieri

  • Authors set to John Palmieri
  • Commit set to c77ecb07a599287d5e6577fa87f1faf71bc5e6ef
  • Status changed from new to needs_review

Here's a branch. I removed hg, kash, and M2 from the scripts to be installed, since those are not connected to Sage packages anymore. Questions:

  • should we remove from .dist import install_scripts from sage.misc.all?
  • install_scripts is used in docker/Dockerfile. Is this necessary?

New commits:

​c77ecb0trac 30207: deprecate install_scripts (from sage.misc.dist)

comment:9 Changed 2 months ago by mkoeppe

  • Cc saraedum added

Cc'ing the maintainer of docker/Dockerfile

comment:11 Changed 8 weeks ago by mkoeppe

  • Description modified (diff)

comment:12 in reply to: ↑ 10 Changed 8 weeks ago by mkoeppe

Replying to jhpalmieri:

I did not do any updating of ​https://doc.sagemath.org/html/en/installation/source.html#installation-in-a-multiuser-environment, by the way.

I've moved this task to #33787

comment:13 Changed 8 weeks ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:14 Changed 8 weeks ago by jhpalmieri

Thanks! Someone can take care of docker/Dockerfile in a later ticket, if it's an issue.

comment:15 in reply to: ↑ 8 Changed 8 weeks ago by mkoeppe

Replying to jhpalmieri:

  • should we remove from .dist import install_scripts from sage.misc.all?

No, only after removing the function, I'd say.

comment:16 Changed 6 weeks ago by vbraun

  • Branch changed from u/jhpalmieri/deprecate-install-scripts to c77ecb07a599287d5e6577fa87f1faf71bc5e6ef
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.