Opened 2 years ago
Last modified 4 months ago
#30189 new task
Add Examples to Manifolds Catalog — at Version 12
Reported by: | gh-mjungmath | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.7 |
Component: | manifolds | Keywords: | |
Cc: | egourgoulhon, tscrim, gh-tobiasdiez | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
The current catalog is nice to have but still very limited or incomplete. Constructing some examples in the current catalog also takes a lot of time.
While improving and extend this, it is also a good opportunity to expand the tutorials a little bit. Furthermore, most of our docstring examples are based on the 2-sphere. Hence we can perhaps shorten or simplify some parts of the documentation.
Step 1: rearrange folder structure (#30799)
Step 2: unification/improvement/extension of preexisting models
- Add Orientation to
EuclideanSpace
- Sphere (#30804)
- Kerr
- Minkowski
- Torus
Step 3: add new examples
- Real Projective Space
- Complex Projective Space
Step 4: improve the tutorial/doctests
- simplify preexisting 2-sphere examples
- add thorough tutorial with old/new models
Change History (12)
comment:1 follow-up: ↓ 2 Changed 2 years ago by
comment:2 in reply to: ↑ 1 ; follow-up: ↓ 4 Changed 2 years ago by
Replying to egourgoulhon:
This sounds like a very good idea!
Note that in order not to clutter the global namespace, one can let access to the sphere and the hyperbolic space via the manifold catalog. The current version of the catalog is very primitive and the function
Sphere()
in it should call the constructor the sphere class, as soon as the latter is ready.
Ah, that is very nice. Actually, I was not aware that something like that exists. This should be populated somewhere more obvious. Probably in a tutorial?
So, the only thing that should be added now is the hyperbolic space, right?
comment:3 follow-up: ↓ 5 Changed 2 years ago by
By the way, I noticed that the result coming from sage.manifolds.catalog.Sphere
is not even correct:
sage: S.<th, ph> = manifolds.Sphere() sage: S 2-dimensional Riemannian submanifold S embedded in the Euclidean space E^3 sage: S.atlas() [Chart (S, (th, ph))]
This is not a correct atlas.
comment:4 in reply to: ↑ 2 Changed 2 years ago by
Replying to gh-mjungmath:
Ah, that is very nice. Actually, I was not aware that something like that exists. This should be populated somewhere more obvious. Probably in a tutorial?
Indeed, when it is more developed.
So, the only thing that should be added now is the hyperbolic space, right?
No, there remains to introduce a proper sphere class, on the model of EuclideanSpace
, with methods like stereographic_coordinates
.
comment:5 in reply to: ↑ 3 Changed 2 years ago by
Replying to gh-mjungmath:
By the way, I noticed that the result coming from
sage.manifolds.catalog.Sphere
is not even correct:sage: S.<th, ph> = manifolds.Sphere() sage: S 2-dimensional Riemannian submanifold S embedded in the Euclidean space E^3 sage: S.atlas() [Chart (S, (th, ph))]This is not a correct atlas.
Indeed. As I say in comment:1, the catalog is in a primitive stage.
comment:6 Changed 2 years ago by
Now I see what you mean. I first thought that "primitive" was just referring to the amount of examples.
That's good: there's still work to do. :)
comment:7 Changed 2 years ago by
- Cc gh-tobiasdiez added
comment:8 Changed 22 months ago by
- Description modified (diff)
- Summary changed from Add Sphere and Hyperbolic Space Permanently to Add Models to Manifolds Catalog
- Type changed from enhancement to task
comment:9 Changed 22 months ago by
- Description modified (diff)
comment:10 Changed 22 months ago by
- Description modified (diff)
comment:11 Changed 22 months ago by
- Description modified (diff)
- Summary changed from Add Models to Manifolds Catalog to Add Examples to Manifolds Catalog
comment:12 Changed 22 months ago by
- Description modified (diff)
This sounds like a very good idea!
Note that in order not to clutter the global namespace, one can let access to the sphere and the hyperbolic space via the manifold catalog. The current version of the catalog is very primitive and the function
Sphere()
in it should call the constructor the sphere class, as soon as the latter is ready.