Opened 2 years ago

Closed 2 years ago

#30173 closed defect (fixed)

ECL 20.4.24: More trouble with makeinfo

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.2
Component: packages: standard Keywords:
Cc: dimpase, gh-spaghettisalat, gh-mwageringel Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: Completely fixed; Fix reported upstream Work issues:
Branch: 42e6c43 (Commits, GitHub, GitLab) Commit: 42e6c43198528cc864456894cb8476085474ed5a
Dependencies: Stopgaps:

Status badges

Change History (14)

comment:1 Changed 2 years ago by dimpase

this looks like a locale issue - makeinfo is found, but

perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LC_ALL = "C.UTF-8",
	LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
user-guide/embedding.txi:14: warning: unreferenced node `Starting and Stopping'
user-guide/embedding.txi:14: warning: node `Catching Errors and Managing Interrupts' is next for `Starting and Stopping' in sectioning but not in menu
user-guide/embedding.txi:14: warning: node `Embedding ECL - Embedding Reference' is up for `Starting and Stopping' in sectioning but not in menu
user-guide/embedding.txi:11: node `Embedding ECL - Embedding Reference' lacks menu item for `Starting and Stopping' despite being its Up target
user-guide/embedding.txi:127: warning: unreferenced node `Catching Errors and Managing Interrupts'
user-guide/embedding.txi:127: warning: node `Starting and Stopping' is prev for `Catching Errors and Managing Interrupts' in sectioning but not in menu
user-guide/embedding.txi:127: warning: node `Embedding ECL - Embedding Reference' is up for `Catching Errors and Managing Interrupts' in sectioning but not in menu
user-guide/embedding.txi:11: node `Embedding ECL - Embedding Reference' lacks menu item for `Catching Errors and Managing Interrupts' despite being its Up target
make[7]: *** [ecl.info.gz] Error 1
make[6]: *** [info] Error 2
make[5]: *** [doc] Error 2
make[4]: *** [all] Error 2

comment:2 Changed 2 years ago by dimpase

or, perhaps, a very old version of makeinfo (however, it's in /usr/local/bin on a Mac, so a special effort was needed to get an old one...)

comment:3 follow-up: Changed 2 years ago by gh-spaghettisalat

How about just not building the manual at all by passing --disable-manual to the configure script? Running sagemath doesn't require the manual to be there anyway.

comment:4 in reply to: ↑ 3 Changed 2 years ago by mkoeppe

Replying to gh-spaghettisalat:

How about just not building the manual at all by passing --disable-manual to the configure script? Running sagemath doesn't require the manual to be there anyway.

Yes, that's what we should do on this ticket

comment:5 Changed 2 years ago by mkoeppe

  • Branch set to u/mkoeppe/ecl_20_4_24__more_trouble_with_makeinfo

comment:6 Changed 2 years ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to c2350315b34523561167367494a703bed67d7825
  • Priority changed from critical to major
  • Status changed from new to needs_review

New commits:

c235031build/pkgs/ecl/spkg-install.in: Do not build the manual

comment:7 Changed 2 years ago by dimpase

disabling this due to a possibly broken tool is a bit lame. Tools are meant to be either working or not installed.

Last edited 2 years ago by dimpase (previous) (diff)

comment:8 Changed 2 years ago by dimpase

a correct way would be to test makeinfo version in ECL itself.

Anyhow, the old makeinfo on macOS which creates problems can be tested for by

makeinfo -c foo 2>&1 | grep invalid

this returns something nonempty on makeinfo 4.8, and will be empty on a modern makeinfo - or when there is no makeinfo available.

I suggest that this test is used in spkg-install to test whether the flag --disable-manual should be used, or not.

comment:9 Changed 2 years ago by dimpase

  • Report Upstream changed from N/A to Completely fixed; Fix reported upstream

I've submitted https://gitlab.com/embeddable-common-lisp/ecl/-/merge_requests/221 upstream, to fix this properly.

comment:10 Changed 2 years ago by mkoeppe

Great. We could still suppress building the manual if "$SAGE_SPKG_INSTALL_DOCS" != yes like on the maxima upgrade ticket (#30063).

comment:11 Changed 2 years ago by git

  • Commit changed from c2350315b34523561167367494a703bed67d7825 to 5e8765e354de92831cc514da9eca775a3b19c8fd

Branch pushed to git repo; I updated commit sha1. New commits:

5e8765ebuild/pkgs/ecl/spkg-install.in: Disable building the manual if SAGE_SPKG_INSTALL_DOCS != yes

comment:12 Changed 2 years ago by git

  • Commit changed from 5e8765e354de92831cc514da9eca775a3b19c8fd to 42e6c43198528cc864456894cb8476085474ed5a

Branch pushed to git repo; I updated commit sha1. New commits:

42e6c43build/pkgs/ecl/spkg-install.in: Add test for makeinfo -c

comment:13 Changed 2 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:14 Changed 2 years ago by vbraun

  • Branch changed from u/mkoeppe/ecl_20_4_24__more_trouble_with_makeinfo to 42e6c43198528cc864456894cb8476085474ed5a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.