#30165 closed defect (fixed)

normalize_coordinates broken for p-adic fields

Reported by: gh-EnderWannabe Owned by:
Priority: trivial Milestone: sage-9.2
Component: dynamics Keywords: gsoc20
Cc: bhutz, paulfili Merged in:
Authors: Alexander Galarraga Reviewers: Paul Fili
Report Upstream: N/A Work issues:
Branch: cec0b4b (Commits, GitHub, GitLab) Commit: cec0b4b779876828d755a781d2f9b90d8dc969ee
Dependencies: Stopgaps:

Status badges

Description

normalize_coordinates in projective_morphism does not properly scale by the GCD of the coefficients over a p-adic field:

sage: P.<x,y> = ProjectiveSpace(Qp(3),1)
sage: f = DynamicalSystem_projective([3*x^2 + 6*y^2, 9*x*y])
sage: f.normalize_coordinates(); QQ(f[0][2,0])
-3

We fix the gcd computation. We also stop scaling by -1 in the p-adic case.

Change History (8)

comment:1 Changed 11 months ago by gh-EnderWannabe

  • Branch set to u/gh-EnderWannabe/padic_normalize_coordinates

comment:2 Changed 11 months ago by gh-EnderWannabe

  • Commit set to 7f1c1deb64f524f27f4ba2084b358c2fdf54941f
  • Status changed from new to needs_review

New commits:

7f1c1de30165: fixed gcd computation, added example/documentation

comment:3 Changed 11 months ago by git

  • Commit changed from 7f1c1deb64f524f27f4ba2084b358c2fdf54941f to cec0b4b779876828d755a781d2f9b90d8dc969ee

Branch pushed to git repo; I updated commit sha1. New commits:

cec0b4b30165: small doc fixes

comment:4 Changed 10 months ago by paulfili

  • Status changed from needs_review to positive_review

comment:5 Changed 10 months ago by vbraun

  • Status changed from positive_review to needs_work

Please fill out the Author & Reviewer field

comment:6 Changed 10 months ago by gh-EnderWannabe

  • Authors set to Alexander Galarraga
  • Reviewers set to Paul Fili
  • Status changed from needs_work to needs_review

comment:7 Changed 10 months ago by paulfili

  • Status changed from needs_review to positive_review

comment:8 Changed 10 months ago by vbraun

  • Branch changed from u/gh-EnderWannabe/padic_normalize_coordinates to cec0b4b779876828d755a781d2f9b90d8dc969ee
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.