Opened 3 years ago

Closed 2 years ago

#30159 closed enhancement (fixed)

Adding new small graph structures

Reported by: gh-Fightlapa Owned by:
Priority: minor Milestone: sage-9.2
Component: graph theory Keywords: graphs
Cc: dcoudert Merged in:
Authors: Jakub Jabłoński Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 5ec6133 (Commits, GitHub, GitLab) Commit: 5ec61331124c57038a0d7fa63ad1f66e624901e2
Dependencies: Stopgaps:

Status badges

Description


Change History (14)

comment:1 Changed 3 years ago by gh-Fightlapa

Priority: major → trivial

comment:2 Changed 3 years ago by gh-Fightlapa

Branch: → public/graphs/new_basic_structures

comment:3 Changed 3 years ago by gh-Fightlapa

Authors: → Jakub Jabłoński
Commit: → 23a7baa2444adb9e96c7eedcb6cc775a4335a2ff
Component: PLEASE CHANGE → graph theory
Keywords: graphs added

New commits:

​23a7baaAdding fork graph, gem graph and bull graph to graph list

comment:4 Changed 3 years ago by gh-Fightlapa

Status: new → needs_review

comment:5 Changed 3 years ago by dimpase

Cc: dcoudert added

comment:6 Changed 3 years ago by dimpase

Priority: trivial → minor
Type: PLEASE CHANGE → enhancement

comment:7 Changed 3 years ago by dcoudert

Hello,

please do the following changes to the 3 methods.

  • use Return instead of Returns 
    -    Returns a gem graph with 5 nodes.
+    Returns a gem graph with 5 nodes.
  • this form is more usual. I know other forms are used in basic.py, but this will be unified in the future. 
    -    EXAMPLES: Construct and show a gem graph
-
-    ::
+    EXAMPLES:
+
+    Construct and show a gem graph::

comment:8 Changed 3 years ago by git

Commit: 23a7baa2444adb9e96c7eedcb6cc775a4335a2ff → 1838d264101892e533b87185f774be75673a7f7e

Branch pushed to git repo; I updated commit sha1. New commits:

​1838d26Fixed docs of new graph structures

comment:9 Changed 3 years ago by dcoudert

Reviewers: → David Coudert
Status: needs_review → positive_review

LGTM.

comment:10 Changed 2 years ago by vbraun

Status: positive_review → needs_work

See patchbot

comment:11 Changed 2 years ago by dcoudert

I didn't see that one, sorry 

sage -t --long --random-seed=0 src/sage/graphs/graph_list.py
**********************************************************************
File "src/sage/graphs/graph_list.py", line 321, in sage.graphs.graph_list.show_graphs
Failed example:
    len(glist)
Expected:
    14
Got:
    17

Also, I suggest to add # long time after g.show() like 

-        sage: g.show()
+        sage: g.show()  # long time

it's not interesting when running doctests to display these graphs, but it is good for the documentation.

comment:12 Changed 2 years ago by git

Commit: 1838d264101892e533b87185f774be75673a7f7e → 5ec61331124c57038a0d7fa63ad1f66e624901e2

Branch pushed to git repo; I updated commit sha1. New commits:

​5ec6133Added long time comment in graph show method, fixed test

comment:13 Changed 2 years ago by dcoudert

Status: needs_work → positive_review

LGTM.

comment:14 Changed 2 years ago by vbraun

Branch: public/graphs/new_basic_structures → 5ec61331124c57038a0d7fa63ad1f66e624901e2
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.