Opened 3 years ago
Closed 2 years ago
#30159 closed enhancement (fixed)
Adding new small graph structures
Reported by:  ghFightlapa  Owned by:  

Priority:  minor  Milestone:  sage9.2 
Component:  graph theory  Keywords:  graphs 
Cc:  dcoudert  Merged in:  
Authors:  Jakub Jabłoński  Reviewers:  David Coudert 
Report Upstream:  N/A  Work issues:  
Branch:  5ec6133 (Commits, GitHub, GitLab)  Commit:  5ec61331124c57038a0d7fa63ad1f66e624901e2 
Dependencies:  Stopgaps: 
Description
Change History (14)
comment:1 Changed 3 years ago by
Priority:  major → trivial 

comment:2 Changed 3 years ago by
Branch:  → public/graphs/new_basic_structures 

comment:3 Changed 3 years ago by
Authors:  → Jakub Jabłoński 

Commit:  → 23a7baa2444adb9e96c7eedcb6cc775a4335a2ff 
Component:  PLEASE CHANGE → graph theory 
Keywords:  graphs added 
comment:4 Changed 3 years ago by
Status:  new → needs_review 

comment:5 Changed 3 years ago by
Cc:  dcoudert added 

comment:6 Changed 3 years ago by
Priority:  trivial → minor 

Type:  PLEASE CHANGE → enhancement 
comment:7 Changed 3 years ago by
Hello,
please do the following changes to the 3 methods.
 use
Return
instead ofReturns
 Returns a gem graph with 5 nodes. + Returns a gem graph with 5 nodes.
 this form is more usual. I know other forms are used in
basic.py
, but this will be unified in the future. EXAMPLES: Construct and show a gem graph   :: + EXAMPLES: + + Construct and show a gem graph::
comment:8 Changed 3 years ago by
Commit:  23a7baa2444adb9e96c7eedcb6cc775a4335a2ff → 1838d264101892e533b87185f774be75673a7f7e 

Branch pushed to git repo; I updated commit sha1. New commits:
1838d26  Fixed docs of new graph structures

comment:9 Changed 3 years ago by
Reviewers:  → David Coudert 

Status:  needs_review → positive_review 
LGTM.
comment:11 Changed 2 years ago by
I didn't see that one, sorry
sage t long randomseed=0 src/sage/graphs/graph_list.py ********************************************************************** File "src/sage/graphs/graph_list.py", line 321, in sage.graphs.graph_list.show_graphs Failed example: len(glist) Expected: 14 Got: 17
Also, I suggest to add # long time
after g.show()
like
 sage: g.show() + sage: g.show() # long time
it's not interesting when running doctests to display these graphs, but it is good for the documentation.
comment:12 Changed 2 years ago by
Commit:  1838d264101892e533b87185f774be75673a7f7e → 5ec61331124c57038a0d7fa63ad1f66e624901e2 

Branch pushed to git repo; I updated commit sha1. New commits:
5ec6133  Added long time comment in graph show method, fixed test

comment:14 Changed 2 years ago by
Branch:  public/graphs/new_basic_structures → 5ec61331124c57038a0d7fa63ad1f66e624901e2 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
New commits:
Adding fork graph, gem graph and bull graph to graph list