Opened 17 months ago

Last modified 3 months ago

#30156 new defect

Remove broken experimental package gambit

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.5
Component: packages: experimental Keywords:
Cc: dimpase, jcampbell, kcrisman, ncohen, vinceknight, tscrim, jhpalmieri Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

It is not compatible with python 3.

https://github.com/mkoeppe/sage/runs/876312037

  [gambit-15.1.1.p0]   make[2]: Leaving directory '/sage/local/var/tmp/sage/build/gambit-15.1.1.p0/src'
  [gambit-15.1.1.p0]   Traceback (most recent call last):
  [gambit-15.1.1.p0]     File "setup.py", line 32, in <module>
  [gambit-15.1.1.p0]       m.Extension.__dict__ = m._Extension.__dict__
  [gambit-15.1.1.p0]   AttributeError: attribute '__dict__' of 'type' objects is not writable
  [gambit-15.1.1.p0]   Error installing Python API
  [gambit-15.1.1.p0]   

Another failure report: cygwin linking trouble - https://groups.google.com/g/sage-devel/c/HisDSCo7zlk/m/dAs5K5OrBwAJ

Upstream looks unattended. The last releases are from 2017.

https://github.com/gambitproject/gambit/issues

http://www.gambit-project.org/

https://github.com/gambitproject/gambit/pull/242

https://repology.org/project/gambit-game-theory/versions

Previous tickets: #24840, #24012

Change History (20)

comment:1 Changed 17 months ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 17 months ago by mkoeppe

  • Description modified (diff)

comment:3 Changed 17 months ago by dimpase

I've also emailed Vince Knight, who might know more about Gambit status.

comment:4 Changed 17 months ago by dimpase

no reply - so let's just remove it.

comment:5 Changed 17 months ago by dimpase

however there is a lot of stuff in src/sage/games/ that needs it.

comment:6 Changed 17 months ago by mkoeppe

  • Cc jhpalmieri added

Let's give people a bit of time to react. This is not urgent. When we have collected a bit more information on Meta-ticket #29900 (Fix optional and experimental packages for Sage 9.2), we can perhaps also send a message to sage-users

comment:7 Changed 17 months ago by tscrim

This is our one current use of game theory in Sage. I think a better solution is to extract PR242 as a patch to Sage. (I forget why this was downgraded to experimental in the first place.) We might also consider forking this to include some of the updates, something I would consider doing, but I probably wouldn't be able to do anything with it long-term.

comment:8 Changed 17 months ago by kcrisman

I agree we should wait on this - perhaps contacting the maintainer of Gambit itself.

comment:9 Changed 16 months ago by dimpase

The primary author got back to me saying that's fine, he'll want to do a better Python API anyway (he considers the current one to be unstable), but not before finishing his term as a dean... That is yes, we ought to remove it.

comment:10 Changed 16 months ago by mkoeppe

remvove "it" = the python interface, or the whole package?

comment:11 Changed 16 months ago by dimpase

the whole package, I suppose

comment:12 Changed 16 months ago by kcrisman

What about the current doctests etc that rely on it? It would be unfortunate to remove them completely - but perhaps need to have some warnings on those files that the Gambit tests are currently broken and to use a previous version of Sage if you need that functionality for now.

comment:13 Changed 16 months ago by jhpalmieri

If no one can install the package, they won't easily be able to run the doctests, so they can stay. If you want to add some warnings where it says "Run sage -i gambit ...", that would probably be a good idea.

comment:14 Changed 16 months ago by mkoeppe

Are there parts of the Sage game theory code depend on the Gambit executables, or does everything depend on the broken Gambit Python library?

comment:15 Changed 13 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:16 follow-up: Changed 9 months ago by chapoton

Gambit 16 does not support Python 3. The current master branch does.

comment:17 in reply to: ↑ 16 Changed 9 months ago by kcrisman

Gambit 16 does not support Python 3. The current master branch does.

Interesting. Maybe it would be worth simply packaging as such? Unfortunately it wouldn't appear to currently be pip-installable.

comment:18 Changed 8 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

comment:19 Changed 8 months ago by mkoeppe

  • Description modified (diff)

comment:20 Changed 3 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5
Note: See TracTickets for help on using tickets.