Opened 14 months ago

Last modified 2 months ago

#30145 needs_work enhancement

deprecate edge_iterator

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-9.5
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers:
Report Upstream: N/A Work issues:
Branch: public/graphs/30145_deprecate_edge_iterator (Commits, GitHub, GitLab) Commit: 1a12ac5a2336e3c8a5292f23ac57e9d827f26883
Dependencies: Stopgaps:

Status badges

Description (last modified by dcoudert)

Now that we have EdgesView for graphs (#27408), we can use .edges(...) instead of .edge_iterator(...). We do the following:

Done:

  • #30265 add missing parameters to method edges to have same behavior than edge_iterator

Todo:

  • use edges instead of edge_iterator in the code
  • make edge_iterator call edges
  • add deprecation warning in edge_iterator

Change History (8)

comment:1 Changed 14 months ago by dcoudert

  • Branch set to public/graphs/30145_deprecate_edge_iterator
  • Commit set to 1a12ac5a2336e3c8a5292f23ac57e9d827f26883
  • Status changed from new to needs_review

New commits:

9a66fc3add functionalities of edge_iterator to edges
ce7db5emake edge_iterator call edges
82f5927use edges instead of edge_iterator in graphs
2a85fdause edges instead of edge_iterator almost everywhere
1a12ac5add deprecation warning in edge_iterator

comment:2 Changed 14 months ago by dcoudert

  • Type changed from PLEASE CHANGE to enhancement

comment:3 Changed 14 months ago by dcoudert

Green bot. Please review.

comment:4 Changed 14 months ago by dcoudert

  • Status changed from needs_review to needs_work

I will split that into several smaller tickets. Too hard to make it at once.

comment:5 Changed 14 months ago by dcoudert

  • Description modified (diff)

comment:6 Changed 13 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:7 Changed 7 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

comment:8 Changed 2 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5

Setting a new milestone for this ticket based on a cursory review.

Note: See TracTickets for help on using tickets.