Opened 13 months ago
Closed 12 months ago
#30127 closed defect (fixed)
cygwinminimal: pip20.1.1 fails to install
Reported by:  mkoeppe  Owned by:  

Priority:  critical  Milestone:  sage9.2 
Component:  porting: Cygwin  Keywords:  
Cc:  embray, slelievre, dimpase  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Dima Pasechnik 
Report Upstream:  Fixed upstream, but not in a stable release.  Work issues:  
Branch:  bc8c54f (Commits, GitHub, GitLab)  Commit:  bc8c54f91dbb84d3487d5d3359a7a3a4a7861f08 
Dependencies:  Stopgaps: 
Description
https://github.com/sagemath/sage/runs/862451271
[pip20.1.1] File "/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/pip20.1.1/src/src/pip/_vendor/urllib3/__init__.py", line 7, in <module> [pip20.1.1] from .connectionpool import HTTPConnectionPool, HTTPSConnectionPool, connection_from_url [pip20.1.1] File "/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/pip20.1.1/src/src/pip/_vendor/urllib3/connectionpool.py", line 29, in <module> [pip20.1.1] from .connection import ( [pip20.1.1] File "/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/pip20.1.1/src/src/pip/_vendor/urllib3/connection.py", line 68, in <module> [pip20.1.1] class HTTPConnection(_HTTPConnection, object): [pip20.1.1] File "/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/pip20.1.1/src/src/pip/_vendor/urllib3/connection.py", line 96, in HTTPConnection [pip20.1.1] default_socket_options = [(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)] [pip20.1.1] AttributeError: module 'socket' has no attribute 'TCP_NODELAY'
The install on cygwinstandard
works fine.
Change History (21)
comment:1 Changed 12 months ago by
comment:2 Changed 12 months ago by
Let's try with the following updates:
 https://pypi.org/project/pip/ 20.2.1 update (https://pip.pypa.io/en/stable/news/)
comment:3 Changed 12 months ago by
 Branch set to u/mkoeppe/cygwin_minimal__pip_20_1_1_fails_to_install
comment:4 Changed 12 months ago by
 Branch u/mkoeppe/cygwin_minimal__pip_20_1_1_fails_to_install deleted
comment:5 Changed 12 months ago by
 Branch set to u/mkoeppe/cygwin_minimal__pip_20_1_1_fails_to_install
 Commit set to 91f21f629cb8267e3b1ca28919e6471752db4e19
comment:6 Changed 12 months ago by
Same with pip 20.2.1  https://github.com/mkoeppe/sage/runs/959258905
comment:7 Changed 12 months ago by
Should probably look at the python3
build log on this system.
comment:8 Changed 12 months ago by
The same error also with pip 20.1.1 and python3 3.8.5 from #27754.
comment:9 Changed 12 months ago by
Apparently caused by a recent change in the Cygwin headers: https://bugs.python.org/issue41374
comment:10 Changed 12 months ago by
 Commit changed from 91f21f629cb8267e3b1ca28919e6471752db4e19 to bc8c54f91dbb84d3487d5d3359a7a3a4a7861f08
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
bc8c54f  build/pkgs/python3/patches/cygwinsockettcpnodelay21649.patch: New

comment:11 Changed 12 months ago by
 Report Upstream changed from N/A to Fixed upstream, but not in a stable release.
comment:12 Changed 12 months ago by
comment:13 Changed 12 months ago by
 Status changed from new to needs_review
comment:14 Changed 12 months ago by
This worked, as can be seen in https://github.com/mkoeppe/sage/runs/959927471
Needs review
comment:15 Changed 12 months ago by
 Reviewers set to https://github.com/mkoeppe/sage/runs/959927471
comment:16 Changed 12 months ago by
 Reviewers changed from https://github.com/mkoeppe/sage/runs/959927471 to https://github.com/mkoeppe/sage/runs/959927471, ...
comment:18 Changed 12 months ago by
 Reviewers changed from https://github.com/mkoeppe/sage/runs/959927471, ... to https://github.com/mkoeppe/sage/runs/959927471, Dima Pasechnik
comment:20 Changed 12 months ago by
 Reviewers changed from https://github.com/mkoeppe/sage/runs/959927471, Dima Pasechnik to Dima Pasechnik
Thanks!
comment:21 Changed 12 months ago by
 Branch changed from u/mkoeppe/cygwin_minimal__pip_20_1_1_fails_to_install to bc8c54f91dbb84d3487d5d3359a7a3a4a7861f08
 Resolution set to fixed
 Status changed from positive_review to closed
Note that pip 20.2 was released.