Opened 3 years ago
Closed 3 years ago
#30118 closed enhancement (fixed)
Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sagespkg
Reported by:  mkoeppe  Owned by:  

Priority:  critical  Milestone:  sage9.2 
Component:  build  Keywords:  
Cc:  jhpalmieri, mjo, ghkliem, fbissey  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  5d13238 (Commits, GitHub, GitLab)  Commit:  5d132389ee3a0d5d07f91a66deb243f780a930bd 
Dependencies:  Stopgaps: 
Description (last modified by )
#29766, #29441, and #29497 introduce build dependencies for packages that are only active when SAGE_CHECK
is not no
.
But whether a package needs its checkdependencies depends on both SAGE_CHECK_PACKAGES
and SAGE_CHECK
.
In this ticket, we move the handling of SAGE_CHECK_PACKAGES
from sagespkg
to the Makefile.
This allows packages to conditionalize dependencies based on the new makefile variables SAGE_CHECK_symengine_py
(for #29497) etc.
Change History (12)
comment:1 Changed 3 years ago by
Branch:  → u/mkoeppe/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg 

comment:2 Changed 3 years ago by
Commit:  → 25393b03b5add035608cd09543b3aa4666d100f9 

Description:  modified (diff) 
comment:3 Changed 3 years ago by
Authors:  → Matthias Koeppe 

Status:  new → needs_review 
comment:4 Changed 3 years ago by
Description:  modified (diff) 

comment:5 Changed 3 years ago by
Cc:  ghkliem added 

Priority:  major → critical 
Marking it as critical as it is needed for CI testing of blocker package upgrade ticket #29766
comment:6 Changed 3 years ago by
Cc:  fbissey added 

comment:7 Changed 3 years ago by
Commit:  25393b03b5add035608cd09543b3aa4666d100f9 → 5d132389ee3a0d5d07f91a66deb243f780a930bd 

Branch pushed to git repo; I updated commit sha1. New commits:
5d13238  Merge tag '9.2.beta5' into t/30118/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg

comment:9 Changed 3 years ago by
Reviewers:  → Dima Pasechnik 

Status:  needs_review → positive_review 
looks good as refactoring. We'll see how the conditional deps work on followup tickets, I suppose
comment:12 Changed 3 years ago by
Branch:  u/mkoeppe/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg → 5d132389ee3a0d5d07f91a66deb243f780a930bd 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sagespkg