Opened 23 months ago

Closed 22 months ago

#30118 closed enhancement (fixed)

Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sage-spkg

Reported by: mkoeppe Owned by:
Priority: critical Milestone: sage-9.2
Component: build Keywords:
Cc: jhpalmieri, mjo, gh-kliem, fbissey Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 5d13238 (Commits, GitHub, GitLab) Commit: 5d132389ee3a0d5d07f91a66deb243f780a930bd
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

#29766, #29441, and #29497 introduce build dependencies for packages that are only active when SAGE_CHECK is not no.

But whether a package needs its check-dependencies depends on both SAGE_CHECK_PACKAGES and SAGE_CHECK.

In this ticket, we move the handling of SAGE_CHECK_PACKAGES from sage-spkg to the Makefile.

This allows packages to conditionalize dependencies based on the new makefile variables SAGE_CHECK_symengine_py (for #29497) etc.

Change History (12)

comment:1 Changed 23 months ago by mkoeppe

  • Branch set to u/mkoeppe/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg

comment:2 Changed 23 months ago by mkoeppe

  • Commit set to 25393b03b5add035608cd09543b3aa4666d100f9
  • Description modified (diff)

New commits:

​25393b0Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sage-spkg

comment:3 Changed 23 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Status changed from new to needs_review

comment:4 Changed 23 months ago by mkoeppe

  • Description modified (diff)

comment:5 Changed 23 months ago by mkoeppe

  • Cc gh-kliem added
  • Priority changed from major to critical

Marking it as critical as it is needed for CI testing of blocker package upgrade ticket #29766

comment:6 Changed 22 months ago by mkoeppe

  • Cc fbissey added

comment:7 Changed 22 months ago by git

  • Commit changed from 25393b03b5add035608cd09543b3aa4666d100f9 to 5d132389ee3a0d5d07f91a66deb243f780a930bd

Branch pushed to git repo; I updated commit sha1. New commits:

​5d13238Merge tag '9.2.beta5' into t/30118/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg

comment:8 Changed 22 months ago by mkoeppe

Merged current beta, needs review

comment:9 Changed 22 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

looks good as refactoring. We'll see how the conditional deps work on follow-up tickets, I suppose

comment:10 Changed 22 months ago by mkoeppe

Thanks!

comment:11 Changed 22 months ago by mkoeppe

Yes, I'm already using this in various test runs.

comment:12 Changed 22 months ago by vbraun

  • Branch changed from u/mkoeppe/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg to 5d132389ee3a0d5d07f91a66deb243f780a930bd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.