Opened 23 months ago
Closed 23 months ago
#30112 closed defect (fixed)
Coercion from ChartFunctionRing to ScalarFieldAlgebra
Reported by: | gh-mjungmath | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | geometry | Keywords: | manifolds, chart_function, scalar_field |
Cc: | egourgoulhon, tscrim | Merged in: | |
Authors: | Michael Jung | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 385c4f9 (Commits, GitHub, GitLab) | Commit: | 385c4f932e3a258143dd37f298b711a307331f32 |
Dependencies: | Stopgaps: |
Description (last modified by )
In some doctests, a coercion from the ring of chart functions to the algebra of scalar fields is used. However, it is not officially populated yet. In this ticket, I add this specific coercion.
Change History (8)
comment:1 Changed 23 months ago by
- Branch set to u/gh-mjungmath/coercion_from_chartfunction_to_scalarfield
comment:2 Changed 23 months ago by
- Cc egourgoulhon tscrim added
- Commit set to 8b983010ce279e5b26f3c5002c24ac33eb84ec51
- Component changed from PLEASE CHANGE to geometry
- Description modified (diff)
- Keywords manifolds chart_function scalar_field added
- Status changed from new to needs_review
- Summary changed from Coercion from ChartFunction to ScalarField to Coercion from ChartFunctionRing to ScalarFieldAlgebra
- Type changed from PLEASE CHANGE to defect
comment:3 Changed 23 months ago by
- Status changed from needs_review to needs_work
comment:4 Changed 23 months ago by
- Commit changed from 8b983010ce279e5b26f3c5002c24ac33eb84ec51 to 0089c6e61a7542cb0c35ac10aaea6734094c3188
Branch pushed to git repo; I updated commit sha1. New commits:
0089c6e | Trac #30112: coercion for differentiable scalar fields
|
comment:5 Changed 23 months ago by
- Commit changed from 0089c6e61a7542cb0c35ac10aaea6734094c3188 to 385c4f932e3a258143dd37f298b711a307331f32
Branch pushed to git repo; I updated commit sha1. New commits:
385c4f9 | Trac #30112: doctest added
|
comment:6 Changed 23 months ago by
- Status changed from needs_work to needs_review
comment:7 Changed 23 months ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
This is a very natural coercion to have. LGTM.
comment:8 Changed 23 months ago by
- Branch changed from u/gh-mjungmath/coercion_from_chartfunction_to_scalarfield to 385c4f932e3a258143dd37f298b711a307331f32
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Trac #30112: coerce map from chart function ring added