Opened 2 years ago

Closed 2 years ago

#30112 closed defect (fixed)

Coercion from ChartFunctionRing to ScalarFieldAlgebra

Reported by: Michael Jung Owned by:
Priority: major Milestone: sage-9.2
Component: geometry Keywords: manifolds, chart_function, scalar_field
Cc: Eric Gourgoulhon, Travis Scrimshaw Merged in:
Authors: Michael Jung Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 385c4f9 (Commits, GitHub, GitLab) Commit: 385c4f932e3a258143dd37f298b711a307331f32
Dependencies: Stopgaps:

Status badges

Description (last modified by Michael Jung)

In some doctests, a coercion from the ring of chart functions to the algebra of scalar fields is used. However, it is not officially populated yet. In this ticket, I add this specific coercion.

Change History (8)

comment:1 Changed 2 years ago by Michael Jung

Branch: → u/gh-mjungmath/coercion_from_chartfunction_to_scalarfield

comment:2 Changed 2 years ago by Michael Jung

Authors: → Michael Jung
Cc: Eric Gourgoulhon Travis Scrimshaw added
Commit: → 8b983010ce279e5b26f3c5002c24ac33eb84ec51
Component: PLEASE CHANGE → geometry
Description: modified (diff)
Keywords: manifolds chart_function scalar_field added
Status: new → needs_review
Summary: Coercion from ChartFunction to ScalarField → Coercion from ChartFunctionRing to ScalarFieldAlgebra
Type: PLEASE CHANGE → defect

New commits:

​8b98301Trac #30112: coerce map from chart function ring added

comment:3 Changed 2 years ago by Michael Jung

Status: needs_review → needs_work

comment:4 Changed 2 years ago by git

Commit: 8b983010ce279e5b26f3c5002c24ac33eb84ec51 → 0089c6e61a7542cb0c35ac10aaea6734094c3188

Branch pushed to git repo; I updated commit sha1. New commits:

​0089c6eTrac #30112: coercion for differentiable scalar fields

comment:5 Changed 2 years ago by git

Commit: 0089c6e61a7542cb0c35ac10aaea6734094c3188 → 385c4f932e3a258143dd37f298b711a307331f32

Branch pushed to git repo; I updated commit sha1. New commits:

​385c4f9Trac #30112: doctest added

comment:6 Changed 2 years ago by Michael Jung

Status: needs_work → needs_review

comment:7 Changed 2 years ago by Travis Scrimshaw

Reviewers: → Travis Scrimshaw
Status: needs_review → positive_review

This is a very natural coercion to have. LGTM.

comment:8 Changed 2 years ago by Volker Braun

Branch: u/gh-mjungmath/coercion_from_chartfunction_to_scalarfield → 385c4f932e3a258143dd37f298b711a307331f32
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.