Opened 23 months ago
Closed 22 months ago
#30109 closed defect (fixed)
Remove mentions of packages KASH and Macaulay2 from tutorials
Reported by: | dimpase | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | documentation | Keywords: | kash, macaulay2 |
Cc: | dimpase, embray, gh-rana-aerea, jhpalmieri, slelievre | Merged in: | |
Authors: | John Palmieri | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | 961242d (Commits, GitHub, GitLab) | Commit: | 961242d71a66f3f1bc21e7abf6107a5237b6a159 |
Dependencies: | Stopgaps: |
Description
These packages are long gone, yet
grep -R KASH src/doc grep -R Macaulay src/doc
return hits such as
Macaulay and KASH are Sage packages
etc.
Change History (12)
comment:1 Changed 23 months ago by
comment:2 Changed 23 months ago by
In fact git grep -w -i kash .
returns lots of hits which should be fixed.
comment:3 Changed 23 months ago by
- Cc dimpase slelievre added
- Keywords kash macaulay2 added
- Summary changed from remove mentions of pacakges KASH and Macaulay2 from tutorials to Remove mentions of packages KASH and Macaulay2 from tutorials
We no longer have SPKGs for them, but still have interfaces to them.
Our interfaces should still work if Sage finds them installed separately.
Macaulay2 and its interface certainly are maintained, not sure about Kash.
comment:4 Changed 23 months ago by
I was thinking about removing all references to packages, e.g., commands like sage -i kash
. Probably remove the doctests in tests/cmdline.py
about kash
. Certainly keep the interface files, but with a change in the instructions for how to install kash
, at least. The instructions at the top of interfaces/macaulay2.py
are not obviously out of date.
comment:5 Changed 23 months ago by
I wonder if we should remove sage --kash
and sage --M2
. Anyway, here is a first draft. I tried to deal with translations, but I probably messed some up, I did Russian only partly, and I didn't do Japanese at all.
comment:6 Changed 23 months ago by
- Branch set to u/jhpalmieri/kash-out
comment:7 Changed 23 months ago by
- Commit set to ed676c931e0bc47f7931a7eedb4784b8c8f3455a
- Status changed from new to needs_review
New commits:
ed676c9 | trac 30109: remove mention of kash and Macaulay2 as Sage packages
|
comment:8 Changed 23 months ago by
- Commit changed from ed676c931e0bc47f7931a7eedb4784b8c8f3455a to 961242d71a66f3f1bc21e7abf6107a5237b6a159
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
961242d | trac 30109: remove mention of kash and Macaulay2 as Sage packages
|
comment:9 Changed 23 months ago by
I added a link to the kash web page (http://page.math.tu-berlin.de/~kant/kash.html), but that page says it hasn't been changed since 2008. So I'm not very confident that it will work, and the top of our file interfaces/kash.py
says "It is not enough to just have KASH installed on your computer", whatever that means.
comment:10 Changed 23 months ago by
- Cc embray gh-rana-aerea added
Hopefully a Japanese speaker can take care of the Japanese tutorial.
comment:11 Changed 22 months ago by
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
Looks good to me. More refinements and translations can be done on follow-up tickets.
comment:12 Changed 22 months ago by
- Branch changed from u/jhpalmieri/kash-out to 961242d71a66f3f1bc21e7abf6107a5237b6a159
- Resolution set to fixed
- Status changed from positive_review to closed
We should also remove these from
src/bin/sage
(best to base on top of #29111 or wait until the next beta when it should be merged).