Opened 2 years ago

Closed 2 years ago

#30081 closed enhancement (fixed)

Cleaning and improving consistency in `distances` methods in graph module

Reported by: vipul73921 Owned by:
Priority: major Milestone: sage-9.2
Component: graph theory Keywords: gsoc2020
Cc: David Coudert Merged in:
Authors: Vipul Gupta Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 90c081b (Commits, GitHub, GitLab) Commit: 90c081ba1612b14d978073c282ee96f1c7225dec
Dependencies: Stopgaps:

Status badges

Description

This ticket aims to improve consistency in distance computation methods such as shortest_path, shortest_path_length, shortest_path_all_pairs etc.

Change History (9)

comment:1 Changed 2 years ago by vipul73921

Branch: public/graphs/30081_distances
Status: newneeds_review

comment:2 Changed 2 years ago by git

Commit: 203efd20054250d66eff8b75ddfd862eb0f724b1

Branch pushed to git repo; I updated commit sha1. New commits:

203efd2improved overall consistency in weight_function

comment:3 in reply to:  2 Changed 2 years ago by vipul73921

Replying to git:

Branch pushed to git repo; I updated commit sha1. New commits:

203efd2improved overall consistency in weight_function

I have made use of weight_function consistent in all distance method.

Have a look at it. Any suggestion will be helpful.

Vipul

comment:4 Changed 2 years ago by David Coudert

have you also checked src/sage/graphs/base/c_graph.pyx ?

comment:5 Changed 2 years ago by git

Commit: 203efd20054250d66eff8b75ddfd862eb0f724b111067fab1d98eeff314dcc7427fdc6ef27906f7c

Branch pushed to git repo; I updated commit sha1. New commits:

11067famade changes in c_graph.pyx

comment:6 Changed 2 years ago by git

Commit: 11067fab1d98eeff314dcc7427fdc6ef27906f7c90c081ba1612b14d978073c282ee96f1c7225dec

Branch pushed to git repo; I updated commit sha1. New commits:

90c081bmade changes in digraph.py

comment:7 Changed 2 years ago by vipul73921

I have done all the changes for improving consistency of weight_function usage.

Tell me, if i have missed something.

Vipul

P.S- weight_function changes in eccentricity , radius, diameter method of graph.py and digraph.py are done in their respective tickets. For digraph.py in #30039 and for graph.py in #29744, #27934

comment:8 Changed 2 years ago by David Coudert

Reviewers: David Coudert
Status: needs_reviewpositive_review

LGTM.

comment:9 Changed 2 years ago by Volker Braun

Branch: public/graphs/30081_distances90c081ba1612b14d978073c282ee96f1c7225dec
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.