Opened 2 years ago
Closed 2 years ago
#30081 closed enhancement (fixed)
Cleaning and improving consistency in `distances` methods in graph module
Reported by:  vipul73921  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  graph theory  Keywords:  gsoc2020 
Cc:  David Coudert  Merged in:  
Authors:  Vipul Gupta  Reviewers:  David Coudert 
Report Upstream:  N/A  Work issues:  
Branch:  90c081b (Commits, GitHub, GitLab)  Commit:  90c081ba1612b14d978073c282ee96f1c7225dec 
Dependencies:  Stopgaps: 
Description
This ticket aims to improve consistency in distance computation methods such as shortest_path
, shortest_path_length
, shortest_path_all_pairs
etc.
Change History (9)
comment:1 Changed 2 years ago by
Branch:  → public/graphs/30081_distances 

Status:  new → needs_review 
comment:2 followup: 3 Changed 2 years ago by
Commit:  → 203efd20054250d66eff8b75ddfd862eb0f724b1 

comment:3 Changed 2 years ago by
comment:5 Changed 2 years ago by
Commit:  203efd20054250d66eff8b75ddfd862eb0f724b1 → 11067fab1d98eeff314dcc7427fdc6ef27906f7c 

Branch pushed to git repo; I updated commit sha1. New commits:
11067fa  made changes in c_graph.pyx

comment:6 Changed 2 years ago by
Commit:  11067fab1d98eeff314dcc7427fdc6ef27906f7c → 90c081ba1612b14d978073c282ee96f1c7225dec 

Branch pushed to git repo; I updated commit sha1. New commits:
90c081b  made changes in digraph.py

comment:7 Changed 2 years ago by
I have done all the changes for improving consistency of weight_function
usage.
Tell me, if i have missed something.
Vipul
P.S weight_function
changes in eccentricity
, radius
, diameter
method of graph.py
and digraph.py
are done in their respective tickets.
For digraph.py
in #30039 and for graph.py
in #29744, #27934
comment:8 Changed 2 years ago by
Reviewers:  → David Coudert 

Status:  needs_review → positive_review 
LGTM.
comment:9 Changed 2 years ago by
Branch:  public/graphs/30081_distances → 90c081ba1612b14d978073c282ee96f1c7225dec 

Resolution:  → fixed 
Status:  positive_review → closed 
Branch pushed to git repo; I updated commit sha1. New commits:
improved overall consistency in weight_function