Opened 3 years ago

Closed 3 years ago

#30077 closed enhancement (fixed)

get rid of _cmp_ for list_clone

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.2
Component: refactoring Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: abee232 (Commits, GitHub, GitLab) Commit: abee232c8b462ae6a0e1d8f7e76212a78d4b85db
Dependencies: Stopgaps:

Status badges

Description

as another step towards removal of _cmp_

Change History (4)

comment:1 Changed 3 years ago by chapoton

Branch: u/chapoton/30077
Commit: abee232c8b462ae6a0e1d8f7e76212a78d4b85db
Status: newneeds_review

New commits:

abee232get rid of _cmp_ in list_clone.pyx

comment:2 Changed 3 years ago by chapoton

Cc: tscrim added

green bot, please review.

Travis, are things all right in Queensland ?

comment:3 in reply to:  2 Changed 3 years ago by tscrim

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Replying to chapoton:

green bot, please review.

LGTM.

Travis, are things all right in Queensland ?

Things are going fairly well. In the middle of finals still, but that is almost over. The state's borders reopened ahead of schedule this past weekend (however Melbourne is not doing so well right now). I am now ready for my poster at FPSAC. Although the big thing I am (still) waiting for is the international border to reopen.

How are things for you?

comment:4 Changed 3 years ago by vbraun

Branch: u/chapoton/30077abee232c8b462ae6a0e1d8f7e76212a78d4b85db
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.