Opened 23 months ago

Closed 22 months ago

Last modified 22 months ago

#30067 closed defect (fixed)

gfortran spkg-configure: Reject versions >= 10

Reported by: mkoeppe Owned by:
Priority: blocker Milestone: sage-9.2
Component: porting Keywords:
Cc: dimpase, bump, mjo, jhpalmieri, fbissey Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: f6b123f (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

(from https://groups.google.com/d/msg/sage-devel/OXOmOjlYQLo/7gOLtzsJCQAJ)

We already reject gcc 10, but if gfortran is installed separately, we also have to check that version.

We also check for gfortran-9 first, and on homebrew, we recommend installing it via brew install gcc@9.

Change History (24)

comment:1 Changed 23 months ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 23 months ago by mkoeppe

  • Cc mjo added

comment:3 Changed 23 months ago by dimpase

just make sure it is possible to override with

./configure --with-gfortran=

hmm, should it be with

./configure FC=

I am confused here

comment:4 Changed 23 months ago by mkoeppe

It can be overridden by ./configure --without-system-gfortran.

Last edited 23 months ago by mkoeppe (previous) (diff)

comment:5 Changed 23 months ago by slelievre

If Homebrew is detected, should we check for gfortran-9 and recommend installing it via brew install gcc@9?

comment:6 Changed 22 months ago by mkoeppe

I hope that we can get #29456 working...

comment:7 Changed 22 months ago by mkoeppe

  • Branch set to u/mkoeppe/gfortran_spkg_configure__reject_versions____10

comment:8 Changed 22 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc jhpalmieri added
  • Commit set to 2ee7c310b68e7f314e8583e8aee6ee6d989f9ee6
  • Description modified (diff)
  • Priority changed from critical to blocker
  • Status changed from new to needs_review

New commits:

4e42135build/pkgs/gfortran/distros/homebrew.txt: Use gcc@9
f018e63configure.ac: Search for gfortran-9 first
2ee7c31build/pkgs/gfortran/spkg-configure.m4: Check gfortran version, reject too old and too new versions

comment:9 Changed 22 months ago by dimpase

where is the list

AC_PROG_FC([gfortran-9 gfortran g95 xlf95 f95 fort ifort ifc efc pgfortran pgf95 lf95 ftn nagfor xlf90 f90 pgf90 pghpf epcf90 g77 xlf f77 frt pgf77 cf77 fort77 fl32 af77])

coming from? I know that Sage sort of works with flang, which is not on the list -not sure if g95 and other old stuff listed still works...

comment:10 follow-up: Changed 22 months ago by mkoeppe

I put "gfortran-9" in front of the autoconf 2.69 default

comment:11 follow-up: Changed 22 months ago by dimpase

by the way, a new Autotools beta version has been released, they promise 2.70 in 3 months. Time to submit bugs we know?

comment:12 in reply to: ↑ 11 Changed 22 months ago by mjo

Replying to dimpase:

by the way, a new Autotools beta version has been released, they promise 2.70 in 3 months. Time to submit bugs we know?

Once the beta is available in Gentoo (https://bugs.gentoo.org/732648) I'll start building sage with it to make sure there are no new problems.

comment:13 Changed 22 months ago by git

  • Commit changed from 2ee7c310b68e7f314e8583e8aee6ee6d989f9ee6 to f6b123f2bb70f27529526eaed2637eeab42ea7f0

Branch pushed to git repo; I updated commit sha1. New commits:

f6b123fAdd gcc@9/9.3.0 stuff to LIBARY_PATH

comment:14 in reply to: ↑ 10 Changed 22 months ago by dimpase

Replying to mkoeppe:

I put "gfortran-9" in front of the autoconf 2.69 default

could you add flang and lfortran there too, just in case?

comment:15 Changed 22 months ago by mkoeppe

That's not within the scope of this ticket.

comment:16 Changed 22 months ago by dimpase

  • Cc fbissey added

can we see tests on GH Actions?

comment:18 Changed 22 months ago by mkoeppe

this can be seen in action for local-homebrew-macos-standard at https://github.com/mkoeppe/sage/runs/878896230

-----------------------------------------------------------------------------
Checking whether SageMath should install SPKG gfortran...
checking the version of gfortran-9... 9.3.0
configure: will use system package and not install SPKG gfortran
-----------------------------------------------------------------------------

comment:19 Changed 22 months ago by mkoeppe

... and for fedora-32-standard at https://github.com/mkoeppe/sage/runs/878897518

Checking whether SageMath should install SPKG gfortran...
checking the version of gfortran... 10
configure: Installing gfortran because gfortran is version 10, which is too recent for this version of Sage
configure: no suitable system package found for SPKG gfortran

(though it does not really make a difference because it had already discovered that gcc is too new)

comment:20 Changed 22 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:21 Changed 22 months ago by mkoeppe

Thanks!

comment:22 Changed 22 months ago by vbraun

  • Branch changed from u/mkoeppe/gfortran_spkg_configure__reject_versions____10 to f6b123f2bb70f27529526eaed2637eeab42ea7f0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:23 Changed 22 months ago by slelievre

  • Commit f6b123f2bb70f27529526eaed2637eeab42ea7f0 deleted

Replying to mkoeppe:

Replying to dimpase:

could you add flang and lfortran there too, just in case?

That's not within the scope of this ticket.

Is there a ticket for that?

comment:24 Changed 22 months ago by mkoeppe

Note: See TracTickets for help on using tickets.