Opened 2 years ago

Closed 2 years ago

#30064 closed defect (fixed)

Fix tox-docker builds broken by #29884

Reported by: mkoeppe Owned by:
Priority: critical Milestone: sage-9.2
Component: porting Keywords:
Cc: dimpase, gh-kliem, jhpalmieri, gh-sheerluck Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: b7bf43b (Commits, GitHub, GitLab) Commit: b7bf43b488ad8ed5e0808dc7d4942c0c32f7a8d9
Dependencies: #29987 Stopgaps:

Status badges

Description

In 9.2.beta3 (​https://github.com/sagemath/sage/runs/837071227): 

Step 13/18 : RUN ./bootstrap
 ---> Running in 371ddf6853f5
rm -rf config configure build/make/Makefile-auto.in
rm -f src/doc/en/installation/*.txt
rm -rf src/doc/en/reference/spkg/*.rst
rm -f src/doc/en/reference/repl/*.txt
src/doc/bootstrap:48: installing src/doc/en/installation/arch.txt and src/doc/en/installation/arch-optional.txt
src/doc/bootstrap:48: installing src/doc/en/installation/debian.txt and src/doc/en/installation/debian-optional.txt
src/doc/bootstrap:48: installing src/doc/en/installation/fedora.txt and src/doc/en/installation/fedora-optional.txt
src/doc/bootstrap:48: installing src/doc/en/installation/cygwin.txt and src/doc/en/installation/cygwin-optional.txt
src/doc/bootstrap:48: installing src/doc/en/installation/homebrew.txt and src/doc/en/installation/homebrew-optional.txt
src/doc/bootstrap:55: installing src/doc/en/reference/spkg/*.rst
src/doc/bootstrap:83: installing src/doc/en/reference/repl/options.txt
src/doc/bootstrap: line 84: src/doc/en/reference/repl/options.txt: No such file or directory
The command '/bin/sh -c ./bootstrap' returned a non-zero code: 1

Change History (6)

comment:1 Changed 2 years ago by mkoeppe

  • Branch set to u/mkoeppe/fix_tox_docker_builds_broken_by__29884

comment:2 Changed 2 years ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc dimpase gh-kliem jhpalmieri gh-sheerluck added
  • Commit set to b7bf43b488ad8ed5e0808dc7d4942c0c32f7a8d9
  • Dependencies set to #29987
  • Status changed from new to needs_review

New commits:

​539c182build/make/install: Do not depend on src/bin/sage-version.sh
​761092cMerge branch 't/29987/build_make_install__do_not_depend_on_src_bin_sage_version_sh' into t/30064/fix_tox_docker_builds_broken_by__29884
​f2efa6asrc/doc/bootstrap: Create the directory src/doc/en/reference/repl if it does not exist
​b7bf43bbuild/bin/write-dockerfile.sh: ADD src/bin for bootstrapping, needed by src/doc/bootstrap after #29884

comment:4 Changed 2 years ago by gh-kliem

  • Reviewers set to Jonathan Kliem
  • Status changed from needs_review to positive_review

LGTM.

Strangly, centos 7 works again. So maybe we can mark #30008 as invalid then.

comment:5 Changed 2 years ago by mkoeppe

Thanks!

comment:6 Changed 2 years ago by vbraun

  • Branch changed from u/mkoeppe/fix_tox_docker_builds_broken_by__29884 to b7bf43b488ad8ed5e0808dc7d4942c0c32f7a8d9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.