#29968 closed enhancement (fixed)

Make algebras doctests ready for random seeds

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: doctest framework Keywords:
Cc: Merged in:
Authors: Jonathan Kliem Reviewers: Markus Wageringel
Report Upstream: N/A Work issues:
Branch: 46c0147 (Commits, GitHub, GitLab) Commit: 46c01475449da5dd62881afcf686d89782b1beff
Dependencies: #29962 Stopgaps:

Status badges

Description

This ticket makes

sage -t --long --random-seed=n src/sage/algebras/

pass for different values n than just 0.

Change History (8)

comment:1 Changed 18 months ago by gh-kliem

  • Dependencies changed from #29662 to #29962

comment:2 Changed 18 months ago by gh-kliem

  • Branch set to public/29968
  • Commit set to 72d41161788684859c9065c9ab82661e05363a54
  • Status changed from new to needs_review

New commits:

da1c6bestart from a "random" random seed for doctesting
b7b836dmake random seed reproducible
eedbe5edocument random_seed
998b1b9default random seed 0 for now
1d7b00edash instead of underscore for command line options
72d4116make algebras fuzz ready

comment:3 Changed 17 months ago by gh-kliem

  • Branch changed from public/29968 to public/29968-reb
  • Commit changed from 72d41161788684859c9065c9ab82661e05363a54 to 445beef054b2f5367ef92f04732ec58faf379559

Currently this QuaternionAlgebra(-11,-1).maximal_order().random_element() gives and element of QuaternionAlgebra(-11,-1). This seems somewhat strange to me.


New commits:

95a2fefMerge branch 'public/29968' of git://trac.sagemath.org/sage into public/29968-reb
445beefbetter doctests

comment:4 Changed 17 months ago by git

  • Commit changed from 445beef054b2f5367ef92f04732ec58faf379559 to 8038412c9009f970ec5597793f022b961880465b

Branch pushed to git repo; I updated commit sha1. New commits:

8038412fix doctest

comment:5 Changed 17 months ago by gh-kliem

  • Branch changed from public/29968-reb to public/29968-reb2
  • Commit changed from 8038412c9009f970ec5597793f022b961880465b to 46c01475449da5dd62881afcf686d89782b1beff

New commits:

b31e2d5Merge branch 'public/29962' of git://trac.sagemath.org/sage into public/29962-reb
2f30dd9small fixes
b62f781doctests do not start from a random seed by default yet
1d99129fix merge conflict
46c0147Merge branch 'public/29968-reb' of git://trac.sagemath.org/sage into public/29968-reb2

comment:6 Changed 16 months ago by gh-mwageringel

  • Reviewers set to Markus Wageringel
  • Status changed from needs_review to positive_review

Ok.

comment:7 Changed 16 months ago by gh-kliem

Thank you.

comment:8 Changed 16 months ago by vbraun

  • Branch changed from public/29968-reb2 to 46c01475449da5dd62881afcf686d89782b1beff
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.