#29967 closed enhancement (fixed)

Make interfaces doctests ready for random seeds

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.3
Component: doctest framework Keywords:
Cc: gh-DaveWitteMorris Merged in:
Authors: Jonathan Kliem Reviewers: Dave Morris
Report Upstream: N/A Work issues:
Branch: fd09637 (Commits, GitHub, GitLab) Commit: fd096371c5b437e6250634d889c2891144d12ad4
Dependencies: Stopgaps:

Status badges

Description

This ticket makes

sage -t --long --random-seed=n src/sage/interfaces/

pass for different values n than just 0.

Change History (9)

comment:1 Changed 18 months ago by gh-kliem

Probably only

sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/interfaces/singular.py  # 3 doctests failed

needs to be fixed.

comment:2 Changed 18 months ago by gh-kliem

  • Dependencies set to #29962

comment:3 Changed 15 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:4 follow-up: Changed 10 months ago by gh-kliem

R[write to console]: 2: R[write to console]: In sqrt(sage10) : R[write to console]: NaNs? produced

R[write to console]: 3: R[write to console]: In sqrt(sage4) : R[write to console]: NaNs? produced }}}

Version 1, edited 10 months ago by gh-kliem (previous) (next) (diff)

comment:5 in reply to: ↑ 4 Changed 10 months ago by gh-kliem

Replying to gh-kliem:

sage -t --long --random-seed=1232131238098 src/sage/interfaces/r.py
too many failed tests, not using stored timings
Running doctests with ID 2021-01-24-13-31-27-fe6ffc5b.
Git branch: develop
Using --optional=4ti2,build,debian,dochtml,e_antic,latte_int,libnauty,lidia,lrslib,mcqd,memlimit,normaliz,pip,pynormaliz,pyroaringbitmap,python_igraph,rubiks,sage,sage_spkg,speaklater,texttable
Doctesting 1 file.
R[write to console]: Warning messages:

R[write to console]: 1: 
R[write to console]: In sage10 + sage6 :
R[write to console]: 
 
R[write to console]:  longer object length is not a multiple of shorter object length

R[write to console]: 2: 
R[write to console]: In sqrt(sage10) :
R[write to console]:  NaNs produced

R[write to console]: 3: 
R[write to console]: In sqrt(sage4) :
R[write to console]:  NaNs produced

sage -t --long --random-seed=1232131238098 src/sage/interfaces/r.py
    [257 tests, 2.53 s]

I'm just going to ignore this warning. Technically, it is not a failed doctest.

comment:6 Changed 10 months ago by gh-kliem

  • Authors set to Jonathan Kliem
  • Branch set to public/29967
  • Cc gh-DaveWitteMorris added
  • Commit set to fd096371c5b437e6250634d889c2891144d12ad4
  • Dependencies #29962 deleted
  • Status changed from new to needs_review

New commits:

fd09637Make interfaces doctests ready for random seeds

comment:7 Changed 10 months ago by gh-DaveWitteMorris

  • Reviewers set to Dave Morris
  • Status changed from needs_review to positive_review

Thanks for fixing this. I tried twenty different seeds and got no doctest failures.

I don't think the warnings from r.py have anything to do with this ticket, and they are certainly not a reason to keep this ticket open. (I get them even with random-seed=0.) I opened ticket #31300 for anyone who is concerned about those warnings.

comment:8 Changed 10 months ago by gh-kliem

Thank you.

comment:9 Changed 10 months ago by vbraun

  • Branch changed from public/29967 to fd096371c5b437e6250634d889c2891144d12ad4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.