Opened 23 months ago
Closed 22 months ago
#29965 closed enhancement (fixed)
Make graphs doctests ready for random seeds
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | doctest framework | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jonathan Kliem | Reviewers: | David Coudert |
Report Upstream: | N/A | Work issues: | |
Branch: | e8a9a90 (Commits, GitHub, GitLab) | Commit: | e8a9a90e00ceae17caaee1956fb0ddc4ed3fe3f0 |
Dependencies: | #29962, #29958 | Stopgaps: |
Description
This ticket makes
sage -t --long --random-seed=n src/sage/graphs/
pass for different values n
than just 0
.
Change History (18)
comment:1 Changed 23 months ago by
- Branch set to public/29965
- Commit set to 3f85d3460e2fb9886b6dfc11cd242d0ea6360646
- Status changed from new to needs_review
comment:2 Changed 23 months ago by
- Dependencies set to #29962
comment:3 Changed 23 months ago by
- Commit changed from 3f85d3460e2fb9886b6dfc11cd242d0ea6360646 to 7dd4282a757c72d42a428d86c56094f280de6195
Branch pushed to git repo; I updated commit sha1. New commits:
7dd4282 | bug in connectivity
|
comment:4 Changed 23 months ago by
- Branch changed from public/29965 to public/29965-reb
- Commit 7dd4282a757c72d42a428d86c56094f280de6195 deleted
comment:5 Changed 23 months ago by
- Commit set to 57a3302c3cbbbeb7f50c3f9dc315056c3e078ba8
Branch pushed to git repo; I updated commit sha1. New commits:
da1c6be | start from a "random" random seed for doctesting
|
b7b836d | make random seed reproducible
|
eedbe5e | document random_seed
|
998b1b9 | default random seed 0 for now
|
1d7b00e | dash instead of underscore for command line options
|
b3ea6ef | Merge branch 'public/29962' of git://trac.sagemath.org/sage into public/29965-reb
|
89d6bcc | make graphs ready for fuzz doctests
|
7dc9cd5 | failing doctest due to missing sort
|
57a3302 | bug in connectivity
|
comment:6 Changed 23 months ago by
- Commit changed from 57a3302c3cbbbeb7f50c3f9dc315056c3e078ba8 to e9204fa7187f5550c11bf352ef30a2163561848a
Branch pushed to git repo; I updated commit sha1. New commits:
e9204fa | improvements of random tests
|
comment:7 Changed 23 months ago by
in sage/graphs/connectivity.pyx
, you added # known bug
, but the issue is fixed in #29958.
in sage/graphs/generators/random.py
it might be better to do
- EXAMPLES: We show the edge list of a random graph with 3 backbone + EXAMPLES: + + We check a random graph with 12 backbone nodes and probabilities `p = 0.7` and `q = 0.3`::
comment:8 Changed 23 months ago by
- Dependencies changed from #29962 to #29962, #29958
comment:9 Changed 23 months ago by
- Commit changed from e9204fa7187f5550c11bf352ef30a2163561848a to f770315dab737fc7ec5da57248bdab0260e418df
comment:10 Changed 23 months ago by
- Reviewers set to David Coudert
- Status changed from needs_review to positive_review
LGTM.
comment:11 Changed 23 months ago by
Thank you.
comment:12 Changed 23 months ago by
- Status changed from positive_review to needs_work
Merge conflict.
comment:13 Changed 23 months ago by
- Status changed from needs_work to needs_review
Fixed merge conflict.
comment:14 Changed 23 months ago by
- Branch changed from public/29965-reb to public/29965-reb2
- Commit changed from f770315dab737fc7ec5da57248bdab0260e418df to e8a9a90e00ceae17caaee1956fb0ddc4ed3fe3f0
comment:15 Changed 22 months ago by
- Status changed from needs_review to positive_review
Successfully tested over 9.2.beta5.
comment:16 Changed 22 months ago by
Thanks again.
comment:17 Changed 22 months ago by
- Status changed from positive_review to needs_work
Merge conflict
comment:18 Changed 22 months ago by
- Branch changed from public/29965-reb2 to e8a9a90e00ceae17caaee1956fb0ddc4ed3fe3f0
- Resolution set to fixed
- Status changed from needs_work to closed
Note: See
TracTickets for help on using
tickets.
New commits:
start from a "random" random seed for doctesting
make random seed reproducible
document random_seed
default random seed 0 for now
dash instead of underscore for command line options
make graphs ready for fuzz doctests
failing doctest due to missing sort