Opened 2 years ago

Closed 2 years ago

#29963 closed enhancement (fixed)

Make geometry doctests ready for random seeds

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: doctest framework Keywords:
Cc: Merged in:
Authors: Jonathan Kliem Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: f7dc36b (Commits, GitHub, GitLab) Commit: f7dc36bfcd54d268361dba1ce2bf2bd6c92b3cd0
Dependencies: #29962, #29904 Stopgaps:

Status badges

Description (last modified by gh-kliem)

This ticket makes 

sage -t --long --random-seed=n src/sage/geometry/

pass for different values n than just 0 except for src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py, which will be taken care of by #29936.

Change History (11)

comment:1 Changed 2 years ago by gh-kliem

  • Branch set to public/29963
  • Commit set to 00c75750324f5a0b70cb2d4a19ea0d5144698fb6
  • Status changed from new to needs_review

Last 10 new commits:

​998b1b9default random seed 0 for now
​23ed583fix doctest in hyperbolic_space/hyperbolic_point
​5283dc4use abs tol flag
​7b244c0modify doctests to the extend that they hold with fuzz
​228f379Merge branch 'public/29936' of git://trac.sagemath.org/sage into public/29962
​5c7e562fix double description of hypercube
​e1bf211remove set_random_seed
​0e7a998Merge branch 'public/29904' of git://trac.sagemath.org/sage into public/29962
​b6a5dc7fix random test in geometry/linear_expression
​00c7575dash instead of underscore for command line options

comment:2 Changed 2 years ago by gh-kliem

  • Branch changed from public/29963 to public/29963-reb
  • Commit changed from 00c75750324f5a0b70cb2d4a19ea0d5144698fb6 to d67da8b3589a1a6bcc3bde15e17014d06ee016cf

New commits:

​6e57f0cMerge branch 'public/29963' of git://trac.sagemath.org/sage into public/29963-reb
​d67da8btest whether a random element has the correct parent

comment:3 Changed 2 years ago by gh-kliem

  • Branch changed from public/29963-reb to public/29963-reb2
  • Commit changed from d67da8b3589a1a6bcc3bde15e17014d06ee016cf to 0f59b95ba4d290f575f627604a3fa154ace106d6

New commits:

​1d7b00edash instead of underscore for command line options
​b31e2d5Merge branch 'public/29962' of git://trac.sagemath.org/sage into public/29962-reb
​2f30dd9small fixes
​b62f781doctests do not start from a random seed by default yet
​1d99129fix merge conflict
​0f59b95fixed merge conflict

comment:4 Changed 2 years ago by gh-kliem

  • Branch changed from public/29963-reb2 to public/29963-reb3
  • Commit changed from 0f59b95ba4d290f575f627604a3fa154ace106d6 to f7dc36bfcd54d268361dba1ce2bf2bd6c92b3cd0

This is not based on #29936 anymore.

Note that #29936 fixes a sign error in geometry/hyperbolic_space/hyperbolic_geodesic.py.

New commits:

​7e4c90bfix doctest in hyperbolic_space/hyperbolic_point
​f7dc36bmake random doctest fuzz ready

comment:5 follow-up: Changed 2 years ago by slabbe

  • Dependencies changed from #29962, #29904, #29936 to #29962, #29904

comment:6 in reply to: ↑ 5 Changed 2 years ago by gh-kliem

If we want to make this independent of #29936, we need to change the objective.

It is just not based on #29936 to avoid constant merge conflicts. However, #29936 needs to be taken care of or we need to mark those things as known bugs.

comment:7 Changed 2 years ago by slabbe

If the issue with src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py is taken care of in another ticket, then the branch on this ticket can go in. It does not have to wait. I would suggest to downgrade the goal of this ticket to what the branch does.

comment:8 Changed 2 years ago by gh-kliem

  • Description modified (diff)

comment:9 Changed 2 years ago by slabbe

  • Reviewers set to Sébastien Labbé
  • Status changed from needs_review to positive_review

works for me

comment:10 Changed 2 years ago by gh-kliem

Thank you.

comment:11 Changed 2 years ago by vbraun

  • Branch changed from public/29963-reb3 to f7dc36bfcd54d268361dba1ce2bf2bd6c92b3cd0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.