Opened 2 years ago
Closed 2 years ago
#29963 closed enhancement (fixed)
Make geometry doctests ready for random seeds
Reported by:  ghkliem  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  doctest framework  Keywords:  
Cc:  Merged in:  
Authors:  Jonathan Kliem  Reviewers:  Sébastien Labbé 
Report Upstream:  N/A  Work issues:  
Branch:  f7dc36b (Commits, GitHub, GitLab)  Commit:  f7dc36bfcd54d268361dba1ce2bf2bd6c92b3cd0 
Dependencies:  #29962, #29904  Stopgaps: 
Description (last modified by )
This ticket makes
sage t long randomseed=n src/sage/geometry/
pass for different values n
than just 0
except for
src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py
, which will be taken care of by #29936.
Change History (11)
comment:1 Changed 2 years ago by
 Branch set to public/29963
 Commit set to 00c75750324f5a0b70cb2d4a19ea0d5144698fb6
 Status changed from new to needs_review
comment:2 Changed 2 years ago by
 Branch changed from public/29963 to public/29963reb
 Commit changed from 00c75750324f5a0b70cb2d4a19ea0d5144698fb6 to d67da8b3589a1a6bcc3bde15e17014d06ee016cf
comment:3 Changed 2 years ago by
 Branch changed from public/29963reb to public/29963reb2
 Commit changed from d67da8b3589a1a6bcc3bde15e17014d06ee016cf to 0f59b95ba4d290f575f627604a3fa154ace106d6
New commits:
1d7b00e  dash instead of underscore for command line options

b31e2d5  Merge branch 'public/29962' of git://trac.sagemath.org/sage into public/29962reb

2f30dd9  small fixes

b62f781  doctests do not start from a random seed by default yet

1d99129  fix merge conflict

0f59b95  fixed merge conflict

comment:4 Changed 2 years ago by
 Branch changed from public/29963reb2 to public/29963reb3
 Commit changed from 0f59b95ba4d290f575f627604a3fa154ace106d6 to f7dc36bfcd54d268361dba1ce2bf2bd6c92b3cd0
comment:5 followup: ↓ 6 Changed 2 years ago by
 Dependencies changed from #29962, #29904, #29936 to #29962, #29904
comment:6 in reply to: ↑ 5 Changed 2 years ago by
comment:7 Changed 2 years ago by
If the issue with src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py
is taken care of in another ticket, then the branch on this ticket can go in. It does not have to wait. I would suggest to downgrade the goal of this ticket to what the branch does.
comment:8 Changed 2 years ago by
 Description modified (diff)
comment:9 Changed 2 years ago by
 Reviewers set to Sébastien Labbé
 Status changed from needs_review to positive_review
works for me
comment:10 Changed 2 years ago by
Thank you.
comment:11 Changed 2 years ago by
 Branch changed from public/29963reb3 to f7dc36bfcd54d268361dba1ce2bf2bd6c92b3cd0
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
default random seed 0 for now
fix doctest in hyperbolic_space/hyperbolic_point
use abs tol flag
modify doctests to the extend that they hold with fuzz
Merge branch 'public/29936' of git://trac.sagemath.org/sage into public/29962
fix double description of hypercube
remove set_random_seed
Merge branch 'public/29904' of git://trac.sagemath.org/sage into public/29962
fix random test in geometry/linear_expression
dash instead of underscore for command line options