Opened 18 months ago

Closed 2 months ago

#29956 closed defect (fixed)

Bug in KlyachkoBundle_class.random_deformation

Reported by: gh-kliem Owned by:
Priority: critical Milestone: sage-9.5
Component: algebraic geometry Keywords: CPR-Fano toric variety
Cc: vbraun Merged in:
Authors: Andrey Belgorodski Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 5f8fe4e (Commits, GitHub, GitLab) Commit: 5f8fe4e3be144d16f75c0ea680fcccc1a648e656
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-kliem)

The doctest in src/sage/schemes/toric/sheaf/klyachko.py does produce an error on some random seeds:

sage: set_random_seed(151058820726654196682836430928254760259)
sage: P1 = toric_varieties.P1()
sage: H = P1.divisor(0)
sage: V = P1.sheaves.line_bundle(H) + P1.sheaves.line_bundle(-H)
sage: V.cohomology(dim=True, weight=(0,))
(1, 0)
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-12-3095c5f6f78e> in <module>()
----> 1 Vtilde = V.random_deformation()

/home/jonathan/Applications/sage/local/lib/python3.7/site-packages/sage/schemes/toric/sheaf/klyachko.py in random_deformation(self, epsilon)
    953         """
    954         filt = self._filt.random_deformation(epsilon)
--> 955         return self.__class__(self.variety(), filt, check=True)

/home/jonathan/Applications/sage/local/lib/python3.7/site-packages/sage/schemes/toric/sheaf/klyachko.py in __init__(self, toric_variety, multi_filtration, check)
    176                              ' all rays of the fan.')
    177         if not multi_filtration.is_exhaustive():
--> 178             raise ValueError('multi-filtration must be exhaustive')
    179         if not multi_filtration.is_separating():
    180             raise ValueError('multi-filtration must be separating')

ValueError: multi-filtration must be exhaustive

Doctests are marked untested in #32543.

Change History (9)

comment:1 Changed 14 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.3

comment:2 Changed 9 months ago by slelievre

  • Cc vbraun added

comment:3 Changed 7 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Moving to 9.4, as 9.3 has been released.

comment:4 Changed 4 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5

comment:5 Changed 3 months ago by gh-kliem

  • Description modified (diff)

comment:6 Changed 3 months ago by gh-sheerluck

  • src/sage/schemes/toric/sheaf/klyachko.py

    diff --git a/src/sage/schemes/toric/sheaf/klyachko.py b/src/sage/schemes/toric/sheaf/klyachko.py
    index 1ed3ac290b..32821e6d06 100644
    a b class KlyachkoBundle_class(SageObject): 
    952952           (1, 0)
    953953        """
    954954        filt = self._filt.random_deformation(epsilon)
     955        while not filt.is_exhaustive():
     956            filt = self._filt.random_deformation(epsilon)
    955957        return self.__class__(self.variety(), filt, check=True)

comment:7 Changed 2 months ago by gh-kliem

  • Authors set to Andrey Belgorodski
  • Branch set to public/29956
  • Commit set to 5f8fe4e3be144d16f75c0ea680fcccc1a648e656
  • Reviewers set to Jonathan Kliem
  • Status changed from new to needs_review

New commits:

0828599mark unstable tests due to 29956
9fabf8aMerge branch 'u/gh-kliem/mark_doctests_for_29956' of git://trac.sagemath.org/sage into public/29956
5f8fe4emake sure that random multi-filtration is exhaustive

comment:8 Changed 2 months ago by gh-kliem

  • Status changed from needs_review to positive_review

comment:9 Changed 2 months ago by vbraun

  • Branch changed from public/29956 to 5f8fe4e3be144d16f75c0ea680fcccc1a648e656
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.