Opened 2 years ago

Closed 2 years ago

#29952 closed enhancement (fixed)

simplify Seifert matrix code

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.2
Component: algebraic topology Keywords: knot
Cc: tscrim, mmarco, slelievre, soehms Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 4c37b74 (Commits, GitHub, GitLab) Commit: 4c37b7430d01b01c9de3cf026163c8205a4f92dc
Dependencies: Stopgaps:

Status badges

Description

by creating a matrix of smaller size directly

plus some pep8 details in the modified file

Change History (5)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/29952
  • Commit set to 4c37b7430d01b01c9de3cf026163c8205a4f92dc
  • Status changed from new to needs_review

New commits:

4c37b74simplify the Seifert matrix code for links

comment:2 Changed 2 years ago by chapoton

  • Cc tscrim mmarco slelievre soehms added

green bot, please review

comment:3 Changed 2 years ago by chapoton

  • Keywords knot added

comment:4 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/29952 to 4c37b7430d01b01c9de3cf026163c8205a4f92dc
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.