Opened 10 months ago

Closed 5 months ago

#29939 closed defect (duplicate)

Fix precision for hyperbolic geodesics

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: geometry Keywords: hyperbolic geodesic, hyperbolic point
Cc: ​glaun, slelievre, tscrim Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

We decided to fix the underlying sign error in #29936. So this is a duplicate.


In src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py, four doctests claim to be precise up to 1e-9 for random geodesics.

Unfortunately, this assumes set_random_seed(0) and the claim fails by far for many "random" values. In #29936 we specified the precision for which this does hold, which is not much. This should be fixed.

Change History (6)

comment:1 Changed 10 months ago by gh-kliem

  • Keywords hyperbolic geodesic hyperbolic point added

comment:2 Changed 10 months ago by slelievre

  • Cc slelievre added
  • Description modified (diff)
  • Summary changed from Fix precicion for hyperbolic geodesic to Fix precision for hyperbolic geodesics

comment:3 Changed 9 months ago by gh-kliem

  • Cc tscrim added
  • Description modified (diff)
  • Milestone changed from sage-9.2 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

comment:4 Changed 9 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

comment:5 Changed 5 months ago by slelievre

  • Description modified (diff)

comment:6 Changed 5 months ago by slelievre

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.