Changes between Version 5 and Version 22 of Ticket #29936


Ignore:
Timestamp:
Jul 13, 2020, 9:12:28 AM (2 years ago)
Author:
gh-kliem
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29936

    • Property Status changed from needs_review to needs_work
    • Property Authors changed from Jonathan Kliem to
    • Property Cc Michael Orlitzky Travis Scrimshaw Greg Laun Javier Honrubia González added
    • Property Summary changed from Fix wrong precision claims in geometry doctests to Sign error in hyperbolic geodesic
    • Property Dependencies changed from to #29962
    • Property Branch changed from public/29936 to public/geometry/fix_hyperbolic_plane-29936
    • Property Keywords point removed
    • Property Commit changed from 7b244c03bb763bde8a3b95fa2ce5c129562c3260 to 2028478e2e1ffd9294b7a5b0e96626479ce7f546
  • Ticket #29936 – Description

    v5 v22  
    1 Some precision claims in doctests in `geometry/hyperbolic_space/hyperbolic_geodesic.py` only hold in lucky cases.
     1Fuzzing doctests for `geometry/hyperbolic_space/hyperbolic_geodesic.py` revealed a sign error.
    22
    3 Likewise, an equality in `geometry/hyperbolic_space/hyperbolic_point.py` doesn't always hold.
    4 
    5 We add tolerance so those tests pass usually.
    6 
    7 Follow up:
    8 - #29939 fix the precision problem
     3{{{
     4UHP = HyperbolicPlane().UHP()
     5sage: g = UHP.random_geodesic()   # Good one
     6sage: g.start(), g.end()
     7(Point in UHP -9.26728445125634 + 7.15068223909426*I,
     8 Point in UHP -8.57515638592863 + 0.982992065975858*I)
     9sage: g = UHP.random_geodesic()   # Bad one
     10sage: g.start(), g.end()
     11(Point in UHP -4.92591958004554 + 7.81075974592370*I,
     12 Point in UHP -8.44416583993011 + 3.87025183089797*I)
     13}}}