Opened 2 years ago

Closed 2 years ago

#29929 closed enhancement (fixed)

tox.ini: Various CI fixes

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.2
Component: porting Keywords:
Cc: gh-kliem Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: b62f775 (Commits, GitHub, GitLab) Commit: b62f775b3c922b99eccd6f9b71eb68bc554f505c
Dependencies: #29851, #29105, #30064, #30048, #30088, #30118 Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

  • Add a homebrew environment local-homebrew-macos-usrlocal that uses the global homebrew in /usr/local. This will be faster and may be more robust for GitHub Actions builds because "bottles" of more packages can be used. (For a while, for example, all homebrew-standard builds fail because the homebrew ppl package cannot be installed from source - https://github.com/Homebrew/homebrew-core/issues/57499)
  • Disable testsuites that need pip (ssl)

This is on top of:

  • Also, add "make dist" testing to tox.ini (prompted by breakage in #29825). This is #30088
  • Add a macos environment without homebrew, conda: That's a configuration that was causing trouble in #29706 and is so far not tested in the GitHub CI tests. This is added by #30088 too (make dist)

Change History (31)

comment:1 Changed 2 years ago by John Palmieri

I'll repeat a comment I made at #29706: I really needed an environment without homebrew to replicate the failures; just having a minimal homebrew installation, or having one with temporarily moved pkgconfig directories, wasn't enough to get the failures.

(So I'm emphasizing that I'm agreeing with the summary: "without homebrew".)

comment:2 Changed 2 years ago by Matthias Köppe

Description: modified (diff)
Report Upstream: N/AReported upstream. No feedback yet.

comment:3 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:4 Changed 2 years ago by Matthias Köppe

Dependencies: #29851, #29105

comment:5 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:6 Changed 2 years ago by Matthias Köppe

Summary: tox.ini: Add a macos environment without homebrew, condatox.ini: Add a macos environment without homebrew, conda; and other CI fixes

comment:7 Changed 2 years ago by Matthias Köppe

Description: modified (diff)
Summary: tox.ini: Add a macos environment without homebrew, conda; and other CI fixestox.ini: Various CI fixes

comment:8 Changed 2 years ago by Matthias Köppe

Dependencies: #29851, #29105#29851, #29105, #30064

comment:9 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:10 Changed 2 years ago by Matthias Köppe

Branch: u/mkoeppe/tox_ini__add_a_macos_environment_without_homebrew__conda

comment:11 Changed 2 years ago by Matthias Köppe

Commit: bfb2fb439694e7fee3e2a0adfd4b4367915362eb
Dependencies: #29851, #29105, #30064#29851, #29105, #30064, #30088
Description: modified (diff)

New commits:

539c182build/make/install: Do not depend on src/bin/sage-version.sh
761092cMerge branch 't/29987/build_make_install__do_not_depend_on_src_bin_sage_version_sh' into t/30064/fix_tox_docker_builds_broken_by__29884
f2efa6asrc/doc/bootstrap: Create the directory src/doc/en/reference/repl if it does not exist
b7bf43bbuild/bin/write-dockerfile.sh: ADD src/bin for bootstrapping, needed by src/doc/bootstrap after #29884
365ce61Merge branch 'u/mkoeppe/fix_tox_docker_builds_broken_by__29884' of git://trac.sagemath.org/sage into HEAD
1e7becctox.ini [debian-buster, -sid]: IGNORE_MISSING_SYSTEM_PACKAGES=yes because of libpython3.7-dev
fb61a31Merge branch 'u/mkoeppe/tox_ini__debian_bullseye___sid_have_python3_8_instead_of_3_7' of git://trac.sagemath.org/sage into 9.2.beta3+ci-fixes
bfb2fb4tox.ini: Add environment local-homebrew-usrlocal

comment:12 Changed 2 years ago by Matthias Köppe

Dependencies: #29851, #29105, #30064, #30088#29851, #29105, #30064, #30048, #30088

comment:13 Changed 2 years ago by git

Commit: bfb2fb439694e7fee3e2a0adfd4b4367915362eb07d657d95781cd193f04809376d10b2088a429a6

Branch pushed to git repo; I updated commit sha1. New commits:

aded967Merge commit '8195cb821e01e0cb627240d7135d5634c265cab0' of git://trac.sagemath.org/sage into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda
07d657dMerge tag '9.2.beta4' into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda

comment:14 Changed 2 years ago by git

Commit: 07d657d95781cd193f04809376d10b2088a429a6bd15fb95c0720aff65ee8fce1c7c261c7aee40fc

Branch pushed to git repo; I updated commit sha1. New commits:

bd15fb9build/bin/write-dockerfile.sh, tox.ini: Do not run testsuites that need pip (ssl)

comment:15 Changed 2 years ago by Matthias Köppe

Dependencies: #29851, #29105, #30064, #30048, #30088#29851, #29105, #30064, #30048, #30088, #30118

comment:16 Changed 2 years ago by git

Commit: bd15fb95c0720aff65ee8fce1c7c261c7aee40fc5aca2383a65be422c6a43349ff86fabb90d9fabe

Branch pushed to git repo; I updated commit sha1. New commits:

25393b0Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sage-spkg
5aca238Merge branch 't/30118/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg' into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda

comment:17 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:18 Changed 2 years ago by git

Commit: 5aca2383a65be422c6a43349ff86fabb90d9fabed1a2cbf833f020a591777c40abfc5ab26ec04fe0

Branch pushed to git repo; I updated commit sha1. New commits:

a17c655m4/sage_spkg_collect.m4: Do not include script packages in SAGE_SDIST_PACKAGES
827923abootstrap: Accept 2020s in config.guess version check
c30ac54tox.ini: Add local-nobootstrap
de6464d.github/workflows/tox.yml: Add jobs "dist", "local-macos-nohomebrew
775b7f7Trac #30088: add a few explanatory comments to m4/sage_spkg_collect.m4.
160862fm4/sage_spkg_collect.m4: Mention sagelib in the comment
d1a2cbfMerge branch 't/30088/fix__make_sdist___add_test_run_to_github_actions' into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda

comment:19 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:20 Changed 2 years ago by Matthias Köppe

Description: modified (diff)

comment:21 Changed 2 years ago by Dima Pasechnik

is this still "new"?

comment:22 Changed 2 years ago by Matthias Köppe

Authors: Matthias Koeppe
Description: modified (diff)
Status: newneeds_review

comment:23 Changed 2 years ago by Matthias Köppe

The cygwin CI wishlist has been moved to #30154.

Needs review

comment:24 Changed 2 years ago by gh-kliem

Reviewers: Jonathan Kliem

Looks reasonable.

Can you provide an example of this ticket in action (you probably have been using it already anyway?).

What's symengine_py?

comment:25 in reply to:  24 Changed 2 years ago by Matthias Köppe

Replying to gh-kliem:

What's symengine_py?

See #29497

comment:26 in reply to:  24 Changed 2 years ago by Matthias Köppe

Replying to gh-kliem:

Can you provide an example of this ticket in action (you probably have been using it already anyway?).

The SAGE_CHECK_PACKAGES adjustments are used in #29766.

comment:27 Changed 2 years ago by gh-kliem

Status: needs_reviewpositive_review

LGTM.

comment:28 Changed 2 years ago by Matthias Köppe

Thanks!

comment:29 Changed 2 years ago by git

Commit: d1a2cbf833f020a591777c40abfc5ab26ec04fe0b62f775b3c922b99eccd6f9b71eb68bc554f505c
Status: positive_reviewneeds_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

b62f775Merge tag '9.2.beta6' into t/29929/tox_ini__add_a_macos_environment_without_homebrew__conda

comment:30 Changed 2 years ago by Matthias Köppe

Status: needs_reviewpositive_review

comment:31 Changed 2 years ago by Volker Braun

Branch: u/mkoeppe/tox_ini__add_a_macos_environment_without_homebrew__condab62f775b3c922b99eccd6f9b71eb68bc554f505c
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.