Opened 13 years ago
Closed 13 years ago
#2992 closed defect (fixed)
[with patch; positive review] notebook -- help(foo) in the notebook should not word wrap
Reported by: | was | Owned by: | boothby |
---|---|---|---|
Priority: | major | Milestone: | sage-3.0.2 |
Component: | notebook | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This is *very* easy to implement:
- Make it so help is a wrapper around internal help. (Already true?)
- If in notebook then display the result using html and pre. Done.
Attachments (2)
Change History (9)
Changed 13 years ago by
comment:1 Changed 13 years ago by
- Summary changed from notebook -- help(foo) in the notebook should not word wrap to [with patch; needs review] notebook -- help(foo) in the notebook should not word wrap
comment:2 Changed 13 years ago by
- Summary changed from [with patch; needs review] notebook -- help(foo) in the notebook should not word wrap to [with patch; slightly negative review] notebook -- help(foo) in the notebook should not word wrap
This is ugly -- scroll down:
help(interact)
I don't know if this is worth a fully negative review, but I think this looks like crap. Perhaps a pre tag would make it all better?
Changed 13 years ago by
comment:3 Changed 13 years ago by
- Summary changed from [with patch; slightly negative review] notebook -- help(foo) in the notebook should not word wrap to [with patch; needs review] notebook -- help(foo) in the notebook should not word wrap
I completely rewrote help(...) to address the referee remark and to make help(...) vastly more robust when the output is MASSIVE (which it often is). Try, e.g.,
import numpy help(numpy)
with the new version, and your browser will *not* get killed. I had my browser crash in class when teaching with the old version.
Of course the issues with help(interact) are also fixed.
Apply both patches, in order.
comment:4 Changed 13 years ago by
Failed to apply :(
comment:5 Changed 13 years ago by
Works for me.
comment:6 Changed 13 years ago by
- Summary changed from [with patch; needs review] notebook -- help(foo) in the notebook should not word wrap to [with patch; positive review] notebook -- help(foo) in the notebook should not word wrap
comment:7 Changed 13 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged both patches in in Sage 3.0.2.alpha1. The dependecy tree is borked since part 2 depends on #3024 being merged. D'oh
The attached patch does this: