Opened 2 years ago

Closed 22 months ago

#29918 closed enhancement (fixed)

Run test suite for gale transform

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: geometry Keywords: gale transform, test suite
Cc: Merged in:
Authors: Jonathan Kliem Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 61a7ba3 (Commits, GitHub, GitLab) Commit: 61a7ba34ba16ef21f9f2ec5b59525a1fb2a5bf92
Dependencies: #29898, #29903 Stopgaps:

Status badges

Description (last modified by gh-kliem)

We add a method that checks gale transforms and it's inverse.

We also fix two # long time flags for the snub cube:

  • one is missing spaces,
  • the other test certainly doesn't take 30 seconds anymore (I need about 2).

Change History (8)

comment:1 Changed 2 years ago by gh-kliem

  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 2 years ago by gh-kliem

  • Dependencies changed from #29903 to #29898, #29903

comment:3 Changed 2 years ago by gh-kliem

  • Component changed from PLEASE CHANGE to geometry

comment:4 Changed 2 years ago by gh-kliem

  • Branch set to public/29918
  • Commit set to b2556d75d94e011a58fc18e8c689b05b0e7bb4d9
  • Description modified (diff)
  • Status changed from new to needs_review

Last 10 new commits:

5c7e562fix double description of hypercube
206dbb7merged in public/29904
c6ea1ecadded long time flags
5d79b2bsome more testsuites
790dfbcfix trivial vertex facet graphs
d7cca49correct fix for 0-dimensional polyhedron
d62124fMerge branch 'public/29898' of git:// into public/29918
c17428atest suite for gale transform
b7eecfbfix flags for snub cube
b2556d7missing space

comment:5 Changed 2 years ago by git

  • Commit changed from b2556d75d94e011a58fc18e8c689b05b0e7bb4d9 to 61a7ba34ba16ef21f9f2ec5b59525a1fb2a5bf92

Branch pushed to git repo; I updated commit sha1. New commits:

61a7ba3fix failing doctest

comment:6 Changed 22 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:7 Changed 22 months ago by gh-kliem

Thank you.

comment:8 Changed 22 months ago by vbraun

  • Branch changed from public/29918 to 61a7ba34ba16ef21f9f2ec5b59525a1fb2a5bf92
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.