#29909 closed enhancement (fixed)

Add tox as a type=optional, source=pip package

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.2
Component: packages: optional Keywords:
Cc: dimpase, jhpalmieri, fbissey Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 1c2415e (Commits, GitHub, GitLab) Commit: 1c2415eb958b8bf835ca29c1bf00b7f55242e420
Dependencies: #29813 Stopgaps:

Status badges

Description (last modified by mkoeppe)

Follow-up to #29813, which did the same for pytest.

Change History (7)

comment:1 Changed 16 months ago by mkoeppe

  • Dependencies changed from #29345 to #29813

comment:2 Changed 16 months ago by mkoeppe

  • Branch set to u/mkoeppe/add_tox_as_a_type_optional__source_pip_package

comment:3 Changed 16 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 1c2415eb958b8bf835ca29c1bf00b7f55242e420
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

04b4c67build/pkgs/pytest: New
55babfasrc/bin/sage [-i]: Set SAGE_CHECK here so that Makefile dependencies can depend on it
bedc7aebuild/make/Makefile.in: Allow pip packages as dependencies
1c2415ebuild/pkgs/tox: New

comment:4 Changed 15 months ago by mkoeppe

  • Cc dimpase jhpalmieri fbissey added

comment:5 Changed 15 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:6 Changed 15 months ago by mkoeppe

Thanks!

comment:7 Changed 15 months ago by vbraun

  • Branch changed from u/mkoeppe/add_tox_as_a_type_optional__source_pip_package to 1c2415eb958b8bf835ca29c1bf00b7f55242e420
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.