Opened 2 years ago
Closed 22 months ago
#29908 closed enhancement (fixed)
Test method `is_combinatorially_isomorphic`
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.2 |
Component: | geometry | Keywords: | polyhedra, test suite |
Cc: | jipilab, gh-LaisRast | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | a6d49a1 (Commits, GitHub, GitLab) | Commit: | a6d49a199e8ce780350f50bcc8948718350ed1b4 |
Dependencies: | #29898, #29899, #29903 | Stopgaps: |
Description (last modified by )
We add a method that tests is_combinatorially_isomorphic
.
Change History (8)
comment:1 Changed 2 years ago by
- Dependencies set to #29898
comment:2 Changed 2 years ago by
- Branch set to public/29908
- Commit set to 2ba5275d9e27b05106907206ee9de2af6cdad14f
- Dependencies changed from #29898 to #29898, #29899
- Status changed from new to needs_review
comment:3 Changed 2 years ago by
- Dependencies changed from #29898, #29899 to #29898, #29899, #29903
comment:4 Changed 2 years ago by
- Commit changed from 2ba5275d9e27b05106907206ee9de2af6cdad14f to 26890deb5117aa8ae58c7644d2b405c26d261561
Branch pushed to git repo; I updated commit sha1. New commits:
26890de | unused import, unused variable
|
comment:5 Changed 2 years ago by
- Commit changed from 26890deb5117aa8ae58c7644d2b405c26d261561 to a6d49a199e8ce780350f50bcc8948718350ed1b4
Branch pushed to git repo; I updated commit sha1. New commits:
a6d49a1 | typo
|
comment:6 Changed 22 months ago by
- Description modified (diff)
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
- Summary changed from Test method `is_combinatorially_equivalent` to Test method `is_combinatorially_isomorphic`
comment:7 Changed 22 months ago by
Thank you.
comment:8 Changed 22 months ago by
- Branch changed from public/29908 to a6d49a199e8ce780350f50bcc8948718350ed1b4
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
fix trivial vertex facet graphs
correct fix for 0-dimensional polyhedron
Merge branch 'public/29898' of git://trac.sagemath.org/sage into public/29908
implement _test_is_combinatorially_isomorphic
fix universe from Hrep for cdd
correctly detect the empty polyhedron
trivial inequality
also fix it for initialization from Hrep and Vrep
Merge branch 'public/29899' of git://trac.sagemath.org/sage into public/29908
remove numerically complicated test