Opened 10 months ago

Closed 9 months ago

#29908 closed enhancement (fixed)

Test method `is_combinatorially_isomorphic`

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: geometry Keywords: polyhedra, test suite
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: a6d49a1 (Commits, GitHub, GitLab) Commit: a6d49a199e8ce780350f50bcc8948718350ed1b4
Dependencies: #29898, #29899, #29903 Stopgaps:

Status badges

Description (last modified by mkoeppe)

We add a method that tests is_combinatorially_isomorphic.

Change History (8)

comment:1 Changed 10 months ago by gh-kliem

  • Dependencies set to #29898

comment:2 Changed 10 months ago by gh-kliem

  • Branch set to public/29908
  • Commit set to 2ba5275d9e27b05106907206ee9de2af6cdad14f
  • Dependencies changed from #29898 to #29898, #29899
  • Status changed from new to needs_review

Last 10 new commits:

​790dfbcfix trivial vertex facet graphs
​d7cca49correct fix for 0-dimensional polyhedron
​7c15f9eMerge branch 'public/29898' of git://trac.sagemath.org/sage into public/29908
​bc5d247implement _test_is_combinatorially_isomorphic
​e41d698fix universe from Hrep for cdd
​e055bc7correctly detect the empty polyhedron
​7eba64dtrivial inequality
​067fb16also fix it for initialization from Hrep and Vrep
​4609affMerge branch 'public/29899' of git://trac.sagemath.org/sage into public/29908
​2ba5275remove numerically complicated test

comment:3 Changed 10 months ago by gh-kliem

  • Dependencies changed from #29898, #29899 to #29898, #29899, #29903

comment:4 Changed 10 months ago by git

  • Commit changed from 2ba5275d9e27b05106907206ee9de2af6cdad14f to 26890deb5117aa8ae58c7644d2b405c26d261561

Branch pushed to git repo; I updated commit sha1. New commits:

​26890deunused import, unused variable

comment:5 Changed 10 months ago by git

  • Commit changed from 26890deb5117aa8ae58c7644d2b405c26d261561 to a6d49a199e8ce780350f50bcc8948718350ed1b4

Branch pushed to git repo; I updated commit sha1. New commits:

​a6d49a1typo

comment:6 Changed 9 months ago by mkoeppe

  • Description modified (diff)
  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review
  • Summary changed from Test method `is_combinatorially_equivalent` to Test method `is_combinatorially_isomorphic`

comment:7 Changed 9 months ago by gh-kliem

Thank you.

comment:8 Changed 9 months ago by vbraun

  • Branch changed from public/29908 to a6d49a199e8ce780350f50bcc8948718350ed1b4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.