Opened 10 months ago

Closed 9 months ago

#29907 closed enhancement (fixed)

Run test suite to check method dilation

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.2
Component: geometry Keywords: polyhedra, test suite
Cc: jipilab, gh-LaisRast Merged in:
Authors: Jonathan Kliem Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 25152f6 (Commits, GitHub, GitLab) Commit: 25152f6b7224c34745ed2431a492e736078f891a
Dependencies: #29899, #29903, #29905 Stopgaps:

Status badges

Description

We add a method to Polyhedron_base that tests the method dilation.

This ticket discovered a bug that is fixed in #29899.

Change History (11)

comment:1 Changed 10 months ago by gh-kliem

  • Branch set to public/29907
  • Commit set to 3cb69aa7dbf517e5cd7a7480e0857acbbecf071f
  • Status changed from new to needs_review

Last 10 new commits:

5c7e562fix double description of hypercube
206dbb7merged in public/29904
c6ea1ecadded long time flags
5d79b2bsome more testsuites
e41d698fix universe from Hrep for cdd
e055bc7correctly detect the empty polyhedron
7eba64dtrivial inequality
067fb16also fix it for initialization from Hrep and Vrep
3a6559bMerge branch 'public/29899' of git://trac.sagemath.org/sage into public/29907
3cb69aaadd _test_dilation

comment:2 Changed 10 months ago by git

  • Commit changed from 3cb69aa7dbf517e5cd7a7480e0857acbbecf071f to bb6110cf37b33152ec09fb4f66ae659d2af8a9b8

Branch pushed to git repo; I updated commit sha1. New commits:

bb6110cpyflakes

comment:3 Changed 10 months ago by gh-kliem

  • Dependencies changed from #29899, #29903 to #29899, #29903, #29905

comment:4 Changed 10 months ago by git

  • Commit changed from bb6110cf37b33152ec09fb4f66ae659d2af8a9b8 to 966210e89bb94a31657e07b4d3dba188f519e2e4

Branch pushed to git repo; I updated commit sha1. New commits:

6eaf649test some basic properties
d91c526Merge branch 'public/29905' of git://trac.sagemath.org/sage into public/29907
966210ereally test the correct double description

comment:5 Changed 10 months ago by gh-kliem

It turns out that the equality check doesn't always detect if a polyhedron is set up correctly. It just assumes this. It will discover this in many instances, but there is no guarantee.

On the other hand the method _test_basic_properties was just introduced to do precisely that (and some other basic properties).

comment:6 Changed 10 months ago by git

  • Commit changed from 966210e89bb94a31657e07b4d3dba188f519e2e4 to 75b97b49b62f50b9f59981504c8911f9a88dbc7a

Branch pushed to git repo; I updated commit sha1. New commits:

75b97b4typo

comment:7 Changed 9 months ago by mkoeppe

  • Status changed from needs_review to needs_work

Needs rebase

comment:8 Changed 9 months ago by gh-kliem

  • Branch changed from public/29907 to public/29907-reb
  • Commit changed from 75b97b49b62f50b9f59981504c8911f9a88dbc7a to 25152f6b7224c34745ed2431a492e736078f891a
  • Status changed from needs_work to needs_review

New commits:

9a57836fixed merge conflict
25152f6small fix

comment:9 Changed 9 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:10 Changed 9 months ago by gh-kliem

Thank you.

comment:11 Changed 9 months ago by vbraun

  • Branch changed from public/29907-reb to 25152f6b7224c34745ed2431a492e736078f891a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.