Opened 2 years ago
Closed 2 years ago
#29904 closed defect (fixed)
Broken double description of hypercube
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-9.2 |
Component: | geometry | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jonathan Kliem | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | e1bf211 (Commits, GitHub, GitLab) | Commit: | e1bf211177ee3b734a314493c9474d9cd7eec661 |
Dependencies: | Stopgaps: |
Description
Turns out the double description of the hypercube after #28866 is not set up incorrectly.
This wasn't detected due to a meaningless doctest.
sage: intervals = [[-2,2]] sage: polytopes.hypercube(1, intervals) A 0-dimensional polyhedron in ZZ^1 defined as the convex hull of 1 vertex
Change History (8)
comment:1 Changed 2 years ago by
- Branch set to public/29904
- Commit set to 5c7e5620e9f8d66f0d131a6bda9da3b923f8330d
- Status changed from new to needs_review
comment:2 Changed 2 years ago by
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
comment:3 Changed 2 years ago by
Thank you.
comment:4 Changed 2 years ago by
We really need to turn off the fake randomness by default in doctests. I've missed so many bugs in exactly the same way.
comment:5 Changed 2 years ago by
I agree. I just posted about this on sage-devel.
comment:6 Changed 2 years ago by
- Commit changed from 5c7e5620e9f8d66f0d131a6bda9da3b923f8330d to e1bf211177ee3b734a314493c9474d9cd7eec661
- Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
e1bf211 | remove set_random_seed
|
comment:7 Changed 2 years ago by
- Status changed from needs_review to positive_review
comment:8 Changed 2 years ago by
- Branch changed from public/29904 to e1bf211177ee3b734a314493c9474d9cd7eec661
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
fix double description of hypercube