Opened 11 years ago

Closed 9 years ago

#299 closed enhancement (fixed)

add make check to all spkg where it is missing

Reported by: was Owned by: mabshoff
Priority: major Milestone: sage-3.1.2
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Project: Go through every spkg in the SAGE standard distribution and add a file

spkg-check

that runs whatever the standard test program is for that package, assuming spkg-install has already run successfully. For example, for many programs (e.g., gmp), this will just be:

make check

or maybe "make test".

The program spkg-check should exit with a 0 code if and only if all tests pass.

Then when building SAGE, if one did something like

export CHECK=1 make

then all spkg-check's would get run along the way. The build would take much longer, but would be much more confidence inspiring.

Change History (5)

comment:1 Changed 10 years ago by mabshoff

  • Milestone set to sage-3.0

comment:2 Changed 10 years ago by mabshoff

The following come from #153 (which I have just closed as a duplicate)

It would also be nice to use the "-t" flag to run spkg-check when building packages:

  sage -i -t packagename.spkg

Cheers,

Michael

comment:3 Changed 10 years ago by mabshoff

  • Owner changed from was to mabshoff
  • Summary changed from make check and its analogues to add make check to all spkg where it is missing

We now have SAGE_CHECK which in case of SAGE_CHECK==yes triggers the automated running of {spkg-check

Cheers,

Michael

comment:4 Changed 10 years ago by mabshoff

  • Status changed from new to assigned

comment:5 Changed 9 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

As far as I know all spkgs now have spkg-checks if applicable. If any spkgs turns out to miss one we need to open a specific ticket for that spkg. Closed.

Cheers,

Michael

Note: See TracTickets for help on using tickets.