Opened 10 months ago
Closed 4 months ago
#29896 closed defect (duplicate)
fix make download
Reported by:  dimpase  Owned by:  

Priority:  major  Milestone:  sageduplicate/invalid/wontfix 
Component:  distribution  Keywords:  download 
Cc:  saliola, mkoeppe, mjo, slelievre, vbraun  Merged in:  
Authors:  Reviewers:  Dima Pasechnik  
Report Upstream:  N/A  Work issues:  
Branch:  u/mkoeppe/fix_make_download (Commits, GitHub, GitLab)  Commit:  039fed7ec5f15feade1ec8368c106fcbe2c71152 
Dependencies:  #30865  Stopgaps: 
Description
This is broken, as reported on https://groups.google.com/d/msg/sagedevel/KA8tI5GsFX4/1KIV2iuIBwAJ
Change History (23)
comment:1 Changed 10 months ago by
 Cc saliola added
comment:2 Changed 10 months ago by
comment:3 Changed 10 months ago by
Although there is another issue: make download
says that it downloads the standard upstream source tarballs, but it actually downloads tarballs for standard, optional, and experimental (after querying) packages. At least one of the experimental database packages is pretty big, so maybe we don't want to do this. With #20104, we could do this:

src/bin/sagedownloadupstream
diff git a/src/bin/sagedownloadupstream b/src/bin/sagedownloadupstream index c5d9afe31e..226806ab7d 100755
a b 1 1 #!/usr/bin/env bash 2 2 3 for pkg in $SAGE_ROOT/build/pkgs/*3 for pkg in `sage package list :standard:` 4 4 do 5 if [ d $ pkg ]; then5 if [ d $SAGE_ROOT/build/pkgs/$pkg ]; then 6 6 sagespkg d `basename $pkg` 7 7 fi 8 8 done
comment:4 Changed 10 months ago by
 Cc mkoeppe added
comment:5 Changed 10 months ago by
I could also imagine trying to use the results from ./configure
to decide which packages to download, which to skip because they are already available from the system. But if someone wants to download once and then distribute to colleagues on a thumb drive, it's a good idea to have all of the standard packages.
comment:6 Changed 9 months ago by
 Cc mjo added
comment:7 followup: ↓ 8 Changed 9 months ago by
Should this be using the same logic as make dist
to determine what to download?
comment:8 in reply to: ↑ 7 Changed 9 months ago by
Replying to jhpalmieri:
Should this be using the same logic as
make dist
to determine what to download?
That's my instinct. We probably don't need both make downloadforsdist
and make download
in that case.
comment:9 Changed 6 months ago by
 Milestone changed from sage9.2 to sage9.3
comment:10 Changed 6 months ago by
 Dependencies set to #30846
comment:11 Changed 6 months ago by
 Branch set to u/mkoeppe/fix_make_download
comment:12 Changed 6 months ago by
 Commit set to 896544fa0d1ccad2526f871afca56945563f9459
The branch "fixes" make download
(and also cleans up src/bin/
a bit more, on top of #30846 and similar earlier tickets).
I don't use this myself, so I don't know what is the best way to proceed regarding "standard" vs. "all" vs. "configured" packages. Perhaps they should be 3 different make targets.
New commits:
044fcc0  Move sagelistpackages from src/bin (sagelib) to build/bin (sage_bootstrap)

896544f  Move sagedownloadupstream from src/bin (sagelib) to build/bin (sage_bootstrap)

comment:13 Changed 5 months ago by
 Cc slelievre added
 Keywords download added
 Priority changed from minor to major
In case that is relevant to the present ticket: our release manager says: "If there were a commandline switch to download all standard + optional + experimental packages then I could test that..." (i.e. test they all download properly, to avoid missing upstream tarballs on our download mirrors after package upgrade tickets get merged).
comment:14 Changed 5 months ago by
 Commit changed from 896544fa0d1ccad2526f871afca56945563f9459 to 039fed7ec5f15feade1ec8368c106fcbe2c71152
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
e09d7da  Move sagedownloadupstream from src/bin (sagelib) to build/bin (sage_bootstrap)

ca87916  Makefile: Update documentation of 'make download'

039fed7  src/doc/en/installation/source.rst: Remove outdated documentation on oldstyle packages

comment:15 Changed 5 months ago by
 Status changed from new to needs_review
comment:16 Changed 5 months ago by
 Cc vbraun added
comment:18 Changed 5 months ago by
 Commit changed from 039fed7ec5f15feade1ec8368c106fcbe2c71152 to e263510e5b2056a82d10ede5fcb15ae9a4ec6369
(pushed to wrong ticket)
comment:19 Changed 5 months ago by
 Commit changed from e263510e5b2056a82d10ede5fcb15ae9a4ec6369 to 039fed7ec5f15feade1ec8368c106fcbe2c71152
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
comment:20 Changed 5 months ago by
Actually best to go through #30865, sage package download :all:
comment:21 Changed 5 months ago by
 Dependencies set to #30865
 Milestone changed from sage9.3 to sageduplicate/invalid/wontfix
comment:22 Changed 5 months ago by
 Reviewers set to Dima Pasechnik
 Status changed from needs_review to positive_review
comment:23 Changed 4 months ago by
 Resolution set to duplicate
 Status changed from positive_review to closed
One option:
Makefile
src/bin:$$PATH && \Then (after #29316) users will be warned that they have to run
./configure
first. For me, if I've run./configure
, this modified version ofmake download
works.